clients
clients copied to clipboard
[deps] Platform: Update Rust crate windows to v0.58.0
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| windows | dependencies | minor | =0.57.0 -> =0.58.0 |
Release Notes
microsoft/windows-rs (windows)
v0.58.0
This release includes updates to metadata for new or fixed API definitions (#3111, #3136), various improvements and fixes to code generation, compliance with new Rust warnings, additional COM authoring support improvements (#3065), limited non-Windows support (#3135), and more.
It includes major updates to the following crates, mainly due to breaking changes in metadata for API definitions.
riddle0.58.0windows0.58.0windows-bindgen0.58.0windows-core0.58.0windows-implement0.58.0windows-interface0.58.0windows-metadata0.58.0
It also includes major updates to the following utility crates.
windows-result0.2.0windows-registry0.2.0
The windows-result crate now provides limited non-Windows support, and the windows-registry crate offers new lossless queries for binary and wide string values.
And it includes minor updates to the windows-targets crates, with the addition of several new APIs.
windows-targets0.52.6
This release also includes the first published version of the windows-strings crate, moving the string types from the windows-core crate into a dedicated crate as a smaller dependency. It also offers an efficient HSTRING builder (#3133).
To clarify, the only crates that continue to support limited non-Windows builds are:
windows-bindgenandwindows-metadatafor code generation on non-Windows platforms.windows-coreandwindows-resultfor COM support on non-Windows platforms.
What's Changed
- Fix default
rustfmtfor repo by @kennykerr in https://github.com/microsoft/windows-rs/pull/3084 - Simplify standalone test by calling
windows-bindgendirectly by @kennykerr in https://github.com/microsoft/windows-rs/pull/3086 - Disable docs and tests for test crates by @kennykerr in https://github.com/microsoft/windows-rs/pull/3085
- Simplify pointer writes in generated code by @kennykerr in https://github.com/microsoft/windows-rs/pull/3089
- Infer return type in generated bindings by @kennykerr in https://github.com/microsoft/windows-rs/pull/3090
- Allow
windows-resultto work on non-Windows platforms by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3082 - Change tests/standalone so that a tool regenerates its sources by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3091
- Bump braces from 3.0.2 to 3.0.3 in /web/features by @dependabot in https://github.com/microsoft/windows-rs/pull/3092
- Use malloc on non-Windows platforms by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3095
- COM interface impls move from MyApp to MyApp_Impl ("outer" object) by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3065
- Workaround for false dead code warning by @kennykerr in https://github.com/microsoft/windows-rs/pull/3098
- The
Debugderive macro does not need to be qualified by @kennykerr in https://github.com/microsoft/windows-rs/pull/3097 - Harden detection of missing nested types by @kennykerr in https://github.com/microsoft/windows-rs/pull/3099
- Use tools to generate bindings for library crates by @kennykerr in https://github.com/microsoft/windows-rs/pull/3102
- Allow
unusedto deal with new warning about "unused" private fields in structs by @kennykerr in https://github.com/microsoft/windows-rs/pull/3103 - Remove
miodependency by @kennykerr in https://github.com/microsoft/windows-rs/pull/3107 - Support some edge cases for the next Win32 metadata update by @kennykerr in https://github.com/microsoft/windows-rs/pull/3109
- Simplify how extension code for
windowscrate works by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3110 - Directly invoke bindgen instead of recursively calling
cargo run ...by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3113 - Update Win32 metadata by @kennykerr in https://github.com/microsoft/windows-rs/pull/3111
- Don't compile
windowsandwindows-sysin unit test mode by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3112 - Remove unused dependencies by @kennykerr in https://github.com/microsoft/windows-rs/pull/3117
- Test cross-compilation with stable gnullvm targets by @mati865 in https://github.com/microsoft/windows-rs/pull/3104
- Add flexible registry type and byte query support by @kennykerr in https://github.com/microsoft/windows-rs/pull/3120
- Remove unnecessary test cfg checks by @kennykerr in https://github.com/microsoft/windows-rs/pull/3124
- Add
windows-stringscrate by @kennykerr in https://github.com/microsoft/windows-rs/pull/3125 - Lock down
windows-coreinternals by @kennykerr in https://github.com/microsoft/windows-rs/pull/3129 - Remove "std" writer from
windows-bindgenby @kennykerr in https://github.com/microsoft/windows-rs/pull/3130 - Allow
ErrorandResult<()>to be the same size asHRESULTby @sivadeilra in https://github.com/microsoft/windows-rs/pull/3126 - Remove boxing support from
windows-corecrate by @kennykerr in https://github.com/microsoft/windows-rs/pull/3131 - Use conventional testing for
windows_slim_errorsby @kennykerr in https://github.com/microsoft/windows-rs/pull/3132 - Clarify support for non-Windows targets by @kennykerr in https://github.com/microsoft/windows-rs/pull/3135
- Add
HSTRINGbuilder and registry support by @kennykerr in https://github.com/microsoft/windows-rs/pull/3133 - Update Windows metadata to 10.0.26100.1 by @kennykerr in https://github.com/microsoft/windows-rs/pull/3136
- Implement
SendandSyncforWeak<T>by @kennykerr in https://github.com/microsoft/windows-rs/pull/3138 - Remove
Futureimplementation by @kennykerr in https://github.com/microsoft/windows-rs/pull/3142 - Ensure that
HSTRINGbuilder provides initialized memory by @kennykerr in https://github.com/microsoft/windows-rs/pull/3141 - Make new
windows-stringscrate Windows-only by @kennykerr in https://github.com/microsoft/windows-rs/pull/3143 - Release 0.58.0 by @kennykerr in https://github.com/microsoft/windows-rs/pull/3140
Full Changelog: https://github.com/microsoft/windows-rs/compare/0.57.0...0.58.0
Configuration
📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.
Internal tracking:
- ID: PM-11087
- Link: https://bitwarden.atlassian.net/browse/PM-11087
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.47%. Comparing base (
f484228) to head (c6b8888). Report is 2 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #10580 +/- ##
==========================================
- Coverage 33.47% 33.47% -0.01%
==========================================
Files 2875 2875
Lines 89830 89830
Branches 17102 17102
==========================================
- Hits 30075 30068 -7
- Misses 57379 57386 +7
Partials 2376 2376
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
- JS Bundle Analysis - Avoid shipping oversized bundles
⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
- any of the package files in this branch needs updating, or
- the branch becomes conflicted, or
- you click the rebase/retry checkbox if found above, or
- you rename this PR's title to start with "rebase!" to trigger it manually
The artifact failure details are included below:
File name: apps/desktop/desktop_native/Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path apps/desktop/desktop_native/core/Cargo.toml --package [email protected] --precise 0.58.0
Updating crates.io index
error: failed to select a version for the requirement `windows = "^0.57.0"`
candidate versions found which didn't match: 0.58.0
location searched: crates.io index
required by package `homedir v0.3.3`
... which satisfies dependency `homedir = "^0.3.3"` (locked to 0.3.3) of package `desktop_core v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/core)`
... which satisfies path dependency `desktop_core` (locked to 0.0.0) of package `desktop_napi v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/napi)`
Checkmarx One – Scan Summary & Details – a7560f14-1ad3-43d2-abbc-164846c3f8c7
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 50 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 55 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 45 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 50 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 35 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 45 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 50 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 40 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45 |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/totp-countdown/totp-countdown.component.ts: 14 |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/totp-countdown/totp-countdown.component.ts: 15 |
![]() |
Angular_Usage_of_Unsafe_DOM_Sanitizer | /libs/components/src/avatar/avatar.component.ts: 80 |
![]() |
Angular_Usage_of_Unsafe_DOM_Sanitizer | /apps/desktop/src/app/components/avatar.component.ts: 75 |
![]() |
Client_Hardcoded_Domain | /apps/web/src/app/billing/shared/payment/payment.component.ts: 73 |
![]() |
Client_Hardcoded_Domain | /apps/web/src/app/billing/shared/payment/payment.component.ts: 73 |
![]() |
Client_JQuery_Deprecated_Symbols | /libs/importer/src/services/import.service.ts: 467 |
Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️ Warning: custom changes will be lost.

