authenticator-android
authenticator-android copied to clipboard
QA Automation - Locators for Android
🎟️ Tracking
📔 Objective
- Added locators for Android for most of the pages
📸 Screenshots
⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
🦮 Reviewer guidelines
- 👍 (
:+1:) or similar for great changes - 📝 (
:memo:) or ℹ️ (:information_source:) for notes or general info - ❓ (
:question:) for questions - 🤔 (
:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (
:art:) for suggestions / improvements - ❌ (
:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention - 🌱 (
:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt - ⛏ (
:pick:) for minor or nitpick changes
Checkmarx One – Scan Summary & Details – 2497a969-49ae-4986-8aa1-2cf7f41f8c16
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 26 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
@vphan916 if you run ./gradlew detekt before pushing it will catch and correct most of the lint issues. I suggest setting up a pre-commit hook so you don't have to worry about triggering detekt manually.
#!/usr/bin/env bash
echo "Running detekt check..."
OUTPUT="/tmp/detekt-$(date +%s)"
./gradlew detekt > $OUTPUT
EXIT_CODE=$?
if [ $EXIT_CODE -ne 0 ]; then
cat $OUTPUT
rm $OUTPUT
echo "***********************************************"
echo " detekt failed "
echo " Please fix the above issues before committing "
echo "***********************************************"
exit $EXIT_CODE
fi
rm $OUTPUT
@SaintPatrck I pushed a fixed for the gradlew detekt and locator formatting issue, re-requested review whenever you have time
Codecov Report
Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.
Project coverage is 25.58%. Comparing base (
ab4d9b9) to head (af7b939). Report is 2 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...i/authenticator/feature/edititem/EditItemScreen.kt | 0.00% | 9 Missing :warning: |
| ...r/feature/manualcodeentry/ManualCodeEntryScreen.kt | 0.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 25.53% 25.58% +0.05%
==========================================
Files 94 94
Lines 4900 4916 +16
Branches 567 567
==========================================
+ Hits 1251 1258 +7
- Misses 3521 3530 +9
Partials 128 128
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
