Peter Bittner

Results 526 comments of Peter Bittner
trafficstars

Canonical has released [Ubuntu minimal images](https://www.omgubuntu.co.uk/2018/03/ubuntu-has-made-its-minimal-images-even-more-minimal-just-28mb). I recall reading "minimal" is now even the default. Hence, just rebuilding the image may already fix the image size. :+1:

This is an obvious fix (if the source code comment is correct). Can we get this merged? Would be cool, thanks!

Can we merge this PR? This would be super-helpful. The Docker image will be [built automatically](https://hub.docker.com/r/liftoff/gateone/), IIUC. Maybe the image size also gets reduced by this, automagically, as suggested in...

NOTE: `setup.py` should probably [read in `requirements.txt`](https://github.com/liftoff/GateOne/blob/master/setup.py#L16) after this PR is merged. That would be sufficient: ```python def read_file(filename): with open(filename) as thefile: return thefile.read() requires = read_file('requirements.txt') ```

@Adi3000 can you address the review comments from @gpotter2? Then this PR could hopefully get merged.

This is a simple, likely undisputed change. Can we have it merged?

***\*ping\**** :bell: Just a gentle reminder. Please merge or let me know what to adapt.

Any chance this PR is going to be merged soon? IIUC, this change is non-critical, doesn't affect anyone's current workflows and has at least 2 fans. 💯 😀

> So I vote that we lose the `gba` and `gbr` Agreed.

I just noted that `gbl` does the same as `gb` _and_ that in other implementations (e.g. OMZ) it is [assigned to `git blame`](https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/git). Hence, we may also let go of...