Peter Bittner
Peter Bittner
Sure, feel free to submit a PR to fix the implementation. Thank you!
This problem seems to be related to #189. Can you confirm?
- [ ] AFAICS, you're making unrelated changes to `analytical/utils.py`. Would you mind moving that to a separate PR? - [ ] Tests are missing for your changes. Please supply...
> It may take me a minute to figure out how to properly write tests for this. Take a look at the tests that are there. The idea is simple:...
I'm not sure what your question is, but if you want to integrate GA in Django cleanly with [django-analytical](https://pypi.org/project/django-analytical/) and you're a total fresher, start here: 1. [Tutorial](https://django-analytical.readthedocs.io/en/latest/tutorial.html) 1. [Installation...
Fixes #141
Probably it makes more sense now to add these changes to the newly created Matomo tag.
> But now the Travis CI check fails and I don't know why. Any suggestions? Flake8 complains about a missing newline in the test file: > ./analytical/tests/test_tag_matomo.py:157:66: W292 no newline...
This PR needs to be rebased and its conflicts resolved. In addition, some review comments may still need to be addressed. But then it would be ready to be merged....
Your problem is similar to #149 and #217. Django settings is so plain simple, and mixed with classes that causes trouble in our brains. :worried: