python-bitshares icon indicating copy to clipboard operation
python-bitshares copied to clipboard

Published 20 hours ago • verified publisher icon bitshares

Avoid .get for checking falsy objects in Liquidity Pool Update operation

Open squidKid-deluxe opened this issue 5 months ago • 4 comments

squidKid-deluxe avatar Jun 18 '25 20:06 squidKid-deluxe

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 18 '25 20:06 CLAassistant

Thanks. Ideally all similar checks in all operations should all be changed.

abitmore avatar Jun 21 '25 18:06 abitmore

I checked through them, there's only a few and none are causing any foreseeable problems. I was trying to minimize the diff, but if you'd like me to fix those too, I can.

squidKid-deluxe avatar Jun 21 '25 18:06 squidKid-deluxe

To clarify, I'm not asking for anything/changes, just leaving my thoughts. Since @xeroc is the main maintainer of this library, I'll let him decide. @xeroc what do you think?

abitmore avatar Jun 21 '25 18:06 abitmore