python-bitshares icon indicating copy to clipboard operation
python-bitshares copied to clipboard

Published 20 hours ago • verified publisher icon bitshares

64 bit unsigned_int

Open abitmore opened this issue 7 years ago • 3 comments
trafficstars

We're upgrading unsigned_int type in bitshares-core to 64 bit.

  • https://github.com/bitshares/bitshares-core/issues/1088
  • https://github.com/bitshares/bitshares-fc/pull/64

The Python library may need to adapt.

abitmore avatar Aug 22 '18 20:08 abitmore

Good move. Thanks for keeping me posted.

I believe that this would only affect serialization in pybitshares, but there, unsigned_int is not used anywhere but explicit types are used (like UInt32).

closing ...

xeroc avatar Sep 27 '18 10:09 xeroc

The point is we need to use 64 bit data types rather than 32 bit data types. At least, unsigned_int is used in core to serialize object IDs, for example, order_id. I know in bitsharesjs varint32 type was used for this, which should be replaced with varuint64, but I don't know what's used in pybitshares, maybe UInt32? Then some of them need to be replaced with a 64 bit data type (I'm not sure whether all of them need to be replaced though).

Related issue in bitsharesjs is https://github.com/bitshares/bitsharesjs/issues/29.

abitmore avatar Sep 27 '18 11:09 abitmore

Oh! I see. Then pybitshares is indeed affected. Shouldn't be a big deal once I know what parts will change ..

xeroc avatar Sep 28 '18 12:09 xeroc