bitshares1-core icon indicating copy to clipboard operation
bitshares1-core copied to clipboard

Published 20 hours ago • verified publisher icon bitshares

Review all chain rewinding logic

Open vikramrajkumar opened this issue 10 years ago • 3 comments

Semi-recently took a look and account_record indices were not being reverted correctly. Given the duplicate transaction problems today, all of the logic should be reviewed.

vikramrajkumar avatar Dec 17 '14 22:12 vikramrajkumar

Original motivatation: #1129, #1142

vikramrajkumar avatar Dec 24 '14 08:12 vikramrajkumar

  • https://github.com/BitShares/bitshares/commit/f04e5d94e1e946ffa562e1fab3ff030a88d8a31c
  • https://github.com/BitShares/bitshares/commit/30f70cc9d8d070ecd61888785231d27ef16baa97

vikramrajkumar avatar Jan 16 '15 18:01 vikramrajkumar

Should add more sanity checks like: https://github.com/BitShares/bitshares/commit/482417a519be7576e31f8a118324206bccde04c0

vikramrajkumar avatar Jan 20 '15 16:01 vikramrajkumar