bitshares-ui icon indicating copy to clipboard operation
bitshares-ui copied to clipboard

[2.5][2.0.181121-rc1] Integration Testing - Quick Deposit Button Missing

Open toi16 opened this issue 7 years ago • 18 comments
trafficstars

Describe the bug Test https://wallet.bitshares.org/#/market/BTS_OPEN.ETH the "Deposit ETH" buttons in the exchange. Are there two options to "Deposit ETH"?

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://wallet.bitshares.org/#/market/BTS_OPEN.ETH ' ERROR: Only one 'QUICK DEPOSIT' button is present (Openledger) when buying ETH.. NOTE: In Chrome two buttons are shown

Expected behavior Two quick deposit buttons should be present when buying ETH.

Screenshots

firefox deposits

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Safari
  • Version 63.0.3 (64-bit)

Additional context

BitShares.181031

toi16 avatar Nov 16 '18 13:11 toi16

My link was misleading ... apologies.

Please try https://staging.bitshares.org/#/market/BTS_OPEN.ETH

sschiessl-bcp avatar Nov 16 '18 14:11 sschiessl-bcp

Firefox: firefox eth

Only one button present. Initially both 'DEPOSIT ETH' and 'DEPOSIT BTS' buttons were disabled and I had to do a screen refresh before they became enabled. Tooltips initially did not work, however after a refresh they did.

toi16 avatar Nov 16 '18 15:11 toi16

Chrome: The same as Firefox, except tooltips appear to work OK.

Disabled Buttons It appears that if you login using web wallet, with 'Remember Me' Disabled, then logout. The buttons are disabled until you refresh the browser window. Looks as though the 'Remember Me' coding logic is having an effect on disabling the 'DEPOSIT ETH' and 'DEPOSIT BTS' buttons.

toi16 avatar Nov 16 '18 15:11 toi16

If you click on "Deposit ETH" a popup with two choices should appear. That is what I meant and failed to describe properly. Can you please try?

sschiessl-bcp avatar Nov 19 '18 13:11 sschiessl-bcp

Chrome: chrome eth 'Deposit ETH' does pop up with two choices correctly.

Firefox: ff eth When you click on 'DEPOSIT ETH' the modal above appears. There is NO pop up with two choices.

toi16 avatar Nov 19 '18 15:11 toi16

That is both on staging wallet? Wow, totally weird

sschiessl-bcp avatar Nov 19 '18 15:11 sschiessl-bcp

Yes they are both using the same URL (https://staging.bitshares.org/#/market/BTS_OPEN.ETH)

toi16 avatar Nov 19 '18 15:11 toi16

What version does the UI report in both cases in the bottom left? Should be the RC number

sschiessl-bcp avatar Nov 19 '18 15:11 sschiessl-bcp

If it helps the tooltip in Firefox is: data-tip="Gateways provide IOUs on the BitShares Blockchain that are backed by the real asset"

The tooltip in chrome is: data-tip="Deposit ETH, click to open options"

toi16 avatar Nov 19 '18 15:11 toi16

UI Versions: Chrome: bitshares.181121-rc1 Firefox: BitShares.181121-rc1

toi16 avatar Nov 19 '18 15:11 toi16

Your Chrome browser may have issues fetching data that relates to the Gateway functionality. If the UI doesn't think that there is any Gateway related assets to use, it will not give you the option to it either. We may need to check on the underlaying fetching code for this.

startailcoon avatar Nov 19 '18 21:11 startailcoon

This needs investigation, but might simply be due to a short network failure when pinging.

@toi16 could you please open it again and simply reload it a couple of times to see if it consistently only displays one Button? And if it does display one button, can you please post the console error log?

sschiessl-bcp avatar Nov 21 '18 14:11 sschiessl-bcp

I have tried again using Firefox, but even after multiple refreshes I only get the 'DEPOSIT ETH' button followed by the Openledger ETH deposit modal. (No two button option).

Console Log: Your connection was lost app.d0181e3ebf68acc745b8.js:1:585489 Connecting to wss://eu-west-1.bts.crypto-bridge.org app.d0181e3ebf68acc745b8.js:1:585489 synced and subscribed, chainstore ready app.d0181e3ebf68acc745b8.js:1:585489 current node api does not support grouped orders. app.d0181e3ebf68acc745b8.js:1:585489 This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features! staging.bitshares.org Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ library.19c99ed5d0307c67f071.js:20:119395

toi16 avatar Nov 21 '18 14:11 toi16

Thank you very much, I appreciate your responsiveness!

@startailcoon I can reproduce this reliably with browserstack (Win10, Firefox 63), could you have a look at this issue? It might be that this option simply never worked so far in Firefox ...

sschiessl-bcp avatar Nov 21 '18 14:11 sschiessl-bcp

I've put some time into investigating this issue. There seems to be some cache issue somewhere. The reason OPEN.ETH can't be deposited is that BCH is under maintenance on Block Trades. Why this shows up on Chrome, I can't say.

I tried it on Chrome, and I could verify that it did show up, even after clearing the cached settings storage. But after trying to debug the reason, it never showed up again.

I've added the updating of backing assets to the loading page of the exchange to make sure we have an accurate and up to date version once the exchange is loaded.

startailcoon avatar Nov 22 '18 19:11 startailcoon

PR did not fix

sschiessl-bcp avatar Nov 23 '18 08:11 sschiessl-bcp

This would require some more checking then. I'm a bit confused to why it didn't work.

startailcoon avatar Nov 28 '18 19:11 startailcoon

Will dig into this this sprint to sort out this and some other gateway specific issues.

startailcoon avatar Apr 14 '19 17:04 startailcoon