Stefan Jandl

Results 489 comments of Stefan Jandl

> Can we just remove the need to set Debug for DiagnosticLogger to work at all? As in: If there is a `Diagnostic`Logger present, log?

> I disagree. This can be done easily. Could you help us out here on how?

I've run into flaky `Sentry.Tests.MetricAggregatorTests.GetFlushableBuckets_IsThreadsafe` [here](https://github.com/getsentry/sentry-dotnet/actions/runs/7725080445) ``` Expected value to be 100000, but found 99961 (difference of -39). at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message) at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message) at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message) at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)...

> Are we planning on adding a hard dependency on [OpenTelemetry](https://www.nuget.org/packages/OpenTelemetry) to the [Sentry](https://www.nuget.org/packages/Sentry) package? Or would we move Tracing capabilities to the [Sentry.OpenTelemetry](https://www.nuget.org/packages/Sentry.OpenTelemetry#dependencies-body-tab) package? This remains to be discussed....

> we could fairly easily implement our own EnsureSuccessStatusCode for target frameworks below .net5.0. I agree with this.

We've addressed a couple of issues, most notably the bump to [perfview](https://github.com/getsentry/sentry-dotnet/pull/3382). Could you give `4.7.0` a try and see if this has an effect?

> without any success As in: No noticeable improvement?

Thanks for the continuous trying and updates @haneytron.

> I wanted to double check that sampling of Observable instruments (eg ObservableCounter) is on the radar for this? It is now!

Happy to help but I'm not quite following how to reproduce the issue you're running into: You're sending an event via sentry-cli but how and why does that generated envelope...