bitrise-steplib icon indicating copy to clipboard operation
bitrise-steplib copied to clipboard

appdome-build-2secure-android 3.2.1

Open elish266 opened this issue 1 year ago • 3 comments

TagCheck

What to do if the build fails?

At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.

New Pull Request Checklist

Please mark the points which you did / accept.

  • [ ] I will not move an already shared step version's tag to another commit
  • [ ] I read the Step Development Guideline
  • [ ] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
  • [ ] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
  • [ ] I read and accept the Abandoned Step policy

elish266 avatar Aug 27 '24 07:08 elish266

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Eli seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 27 '24 07:08 CLAassistant

Don't forget to follow semantic versioning! Breaking changes (including step inputs) should be in major versions only.

step.yml changes compared to previous version:

--- steps/appdome-build-2secure-android/3.2.0/step.yml	2024-08-27 07:38:15
+++ steps/appdome-build-2secure-android/3.2.1/step.yml	2024-08-27 07:38:16
@@ -1,16 +1,16 @@
-title: Appdome-Build-2Secure for Android
+title: Appdome-Build-2Secure for iOS
 summary: |
-  Builds a mobile app using Appdome's platform
+  Builds an iOS mobile app using Appdome's platform
 description: |
   Integration that allows activating security and app protection features, building and signing mobile apps using Appdome's API. For details see: https://www.appdome.com/how-to/appsec-release-orchestration/mobile-appsec-cicd/use-appdome-build-2secure-step-for-bitrise
-website: https://github.com/Appdome/bitrise-step-appdome-build-2secure-android
-source_code_url: https://github.com/Appdome/bitrise-step-appdome-build-2secure-android
-support_url: https://github.com/Appdome/bitrise-step-appdome-build-2secure-android/issues
-published_at: 2024-08-19T13:49:51.361285+03:00
+website: https://github.com/Appdome/bitrise-step-appdome-build-2secure-ios
+source_code_url: https://github.com/Appdome/bitrise-step-appdome-build-2secure-ios
+support_url: https://github.com/Appdome/bitrise-step-appdome-build-2secure-ios/issues
+published_at: 2024-08-27T10:35:15.775971+03:00
 source:
   git: https://github.com/Appdome/bitrise-step-appdome-build-2secure-android.git
-  commit: b38a88f644eea60308aa458de0d3ffdc087764e9
+  commit: 70a501fdd6d23f8d540a0b4c5d096d2810abc4ff
 project_type_tags:
-- android
+- ios
 type_tags:
 - build
@@ -25,15 +25,13 @@
   - name: curl
 inputs:
-- app_location: null
+- app_location: 
   opts:
     is_required: true
-    summary: URL to app file (apk/aab) or an EnvVar representing its path (i.e. 
-      or )
+    summary: URL to app file (ipa) or an EnvVar representing its path (i.e. )
     title: App file URL or EnvVar
 - opts:
     is_required: false
-    summary: Output app file name. The file extension (aab/apk) will be the same as
-      the original app. If not specified, the default output file will be same as
-      the original app but with Appdome_ prefix.
+    summary: Output app file name (without extension). If not populated, the default
+      output file name will be the same as the original app but with Appdome_ prefix.
     title: Output file name (without extension)
   output_filename: null
@@ -55,37 +53,28 @@
     - Auto-Dev-Signing
   sign_method: On-Appdome
-- gp_signing: "false"
+- certificate_file: null
   opts:
-    category: Google Signing
-    description: Sign the app for Google Play? If 'true', requires 
-      in the Secrets tab.
-    is_required: true
-    title: Google Play Signing
-    value_options:
-    - "true"
-    - "false"
-- google_fingerprint: 
-  opts:
-    category: Google Signing
-    description: Google Sign Fingerprint for Google Play singing, or its Secret variable
-      name.
+    description: Code signing cetificate file name (from the uploaded code signing
+      certificates) to use. If not provided, the LAST certificate among the uploaded
+      files to 'Code Signing & Files' section will be used. If you don't know the
+      file name of the certificate you want to use, download the certificate from
+      the Code Signing & Files section to your computer and type here its file name
+      and extension as was downloaded. Only ONE certificate file is supported.
     is_required: false
-    title: Google Sign Fingerprint
-- fingerprint: 
-  opts:
-    category: Private/Auto-Dev Signing
-    description: Sign Fingerprint (not for Google Play singing), or its Secret variable
-      name.
-    is_required: false
-    title: Sign Fingerprint
+    title: Code signing cetificates (.p12) file name
 - opts:
-    description: Select 'true' to create a Universal.apk file (applies to .aab app
-      types only).
+    description: List of provisioning profile file name/s (with no file extension,
+      separated by commas) from the uploaded provisioning profiles to use. If not
+      provided, all provisioning profiles uploaded to 'Code Signing & Files' section
+      will be used.
     is_required: false
-    title: Secondary Output
-    value_options:
-    - "true"
-    - "false"
-  secondary_output: "false"
+    title: Provisioning profile file name/s
+  provisioning_profiles: null
+- entitlements: null
+  opts:
+    description: iOS Entitlement EnvVar/s (separated by space), required for Auto-Dev-Singing
+      and On-Appdome Signing.
+    is_required: false
+    title: iOS Entitlement EnvVar/s
 - build_logs: "false"
   opts:
@@ -104,5 +93,5 @@
     value_options:
     - None
-    - AWS device farm
+    - AWS_device_farm
     - Bitbar
     - Browserstack
@@ -115,22 +104,10 @@
     - Saucelabs
 outputs:
-- APPDOME_SECURED_APK_PATH: null
+- APPDOME_SECURED_IPA_PATH: null
   opts:
     description: |
-      Local path of the secured .apk file. Available when 'Signing Method' set to 'On-Appdome' or 'Private-Signing'
-    summary: Local path of the secured .apk file
-    title: Secured .apk file path
-- APPDOME_SECURED_AAB_PATH: null
-  opts:
-    description: |
-      Local path of the secured .aab file. Available when 'Signing Method' set to 'On-Appdome' or 'Private-Signing'
-    summary: Local path of the secured .aab file
-    title: Secured .aab file path
-- APPDOME_SECURED_SO_PATH: null
-  opts:
-    description: |
-      Local path of the secured secondary output file (universal apk). Available if Secondary Output is set to 'true' and the original app is .aab type
-    summary: Local path of the secured secondary output file
-    title: Secured secondary output file path (universal apk)
+      Local path of the secured .ipa file. Available when 'Signing Method' set to 'On-Appdome' or 'Private-Signing'
+    summary: Local path of the secured .ipa file
+    title: Secured .ipa file path
 - APPDOME_PRIVATE_SIGN_SCRIPT_PATH: null
   opts:

bitrise-coresteps-bot avatar Aug 27 '24 07:08 bitrise-coresteps-bot

Hi @elish266 this PR is coming as a new Step version for the appdome-build-2secure-android, by looking at the changes it seems many things in the step.yml changes from Android to iOS-related infos. Is this an expected change?

godrei avatar Aug 29 '24 11:08 godrei