Ayato Tokubi
Ayato Tokubi
@saschagrunert Sorry I misread somehow. I just ran `make bin/crio`. ``` go build -trimpath -ldflags '-s -w -X github.com/cri-o/cri-o/internal/version.buildDate='2025-05-12T17:44:22Z' ' -tags "containers_image_ostree_stub apparmor seccomp selinux " -o bin/crio ./cmd/crio go...
@saschagrunert good point. I'll share the result once I test it.
It seems we run into a bug of go GC. ``` ❯ sudo dlv core bin/crio /tmp/core_crio_1896888_1750473238 Type 'help' for list of commands. (dlv) bt 0 0x000000000107be80 in runtime.mallocgcSmallNoscan at...
Nice catch! I tested and it didn't get segfault after updating 1.24.3.
- Where do we want to run the test? - prow or github actions - How do we compare the performance? - Do we need to save the past performance?...
@cri-o/cri-o-maintainers Can you PTAL?
@cri-o/cri-o-maintainers Can anyone give it a review?
Adding some preliminary checks until the host is ready will fix the issue. https://github.com/openshift/release/blob/be90c4211d0e856cb7bae9215fb4002c71765aa8/ci-operator/step-registry/cri-o/common/test/cri-o-common-test-commands.sh#L18