oauth2_proxy icon indicating copy to clipboard operation
oauth2_proxy copied to clipboard

Support for group restriction for Gitlab provider

Open JacobAae opened this issue 9 years ago • 11 comments

Should solve issue https://github.com/bitly/oauth2_proxy/issues/311

JacobAae avatar Oct 21 '16 09:10 JacobAae

@jehiah any plans merging this? I would love to see this merged and released.

rutsky avatar Mar 14 '17 18:03 rutsky

I tested this feature and it works great, except if a user is a member of a lot of groups (or if they're an admin, because in that case the GitLab API returns all the groups, not just those the user is a member of). The GitLab API paginates the list of groups, so I had to add c141ff8da3ce7d865db38ccd4e5c157727a6b0d5 to make it work with more than 20 groups.

BenoitKnecht avatar May 23 '17 08:05 BenoitKnecht

So this pull request will be included in the next release? When will that be approximately?

scriptator avatar Sep 27 '17 08:09 scriptator

could any one merge this?

timrosede avatar Jan 23 '18 20:01 timrosede

We would also appreciate this feature, without this we cannot use gitlab authentication. I vote for merge of this feature.

FUSAKLA avatar Jan 24 '18 13:01 FUSAKLA

Any news on this?

cnkk avatar Feb 26 '18 16:02 cnkk

Been using this in production and I can say that the code has been stable for my setup.

nepeat avatar Mar 16 '18 07:03 nepeat

I've also been running this in production (with c141ff8 applied) for a while now, and it's working as expected.

@JacobAae, do you want to add c141ff8 to this PR, if it looks good to you? Otherwise, I can open a new PR, but I think it makes more sense to keep everything in one place.

Let me know if there's anything I can do to help get this merged.

BenoitKnecht avatar Mar 21 '18 15:03 BenoitKnecht

@BenoitKnecht I've created a patch from your commit and applied to include it in the merge request, as it looks fine. I however doubt this will ever be merged, it has been pending for years, but I know several places where it runs in production.

JacobAae avatar Mar 24 '18 11:03 JacobAae

@jehiah any chance this pull request can get merged?

bgagnon avatar May 04 '18 17:05 bgagnon

Fyi: there is an active discussion about forking this (obviously unmaintained) project here: #628

martin-loetzsch avatar Dec 06 '18 21:12 martin-loetzsch