icsx5
icsx5 copied to clipboard
Fix landscape cut out areas
Purpose
Fixes #712
Adds insets when phone is landscape
Short description
Adds .windowInsetsPadding(WindowInsets.safeDrawing.only(WindowInsetsSides.Horizontal)) to each top child in a Scaffold
Needs proper testing before merge!
Checklist
- [x] The PR has a proper title, description and label.
- [x] I have self-reviewed the PR.
- [x] I have added documentation to complex functions and functions that can be used by other modules.
- [x] I have added reasonable tests or consciously decided to not add tests.
@mcbabo
Thank you for the contribution and your involvement. It's a good start! I tested it and I think it'd be better if the loading bar (blue animated top stripe shown on refresh) would not receive the padding. See the screenshot.
So applying the window insets padding to
LazyColumninCalendarListContentinSubscriptionsScreenHorizontalPagerinEnterUrlComposable(instead ofAddSubscriptionScreen)ColumninSubscriptionSettingsComposable(instead ofAddSubscriptionScreen)
would look better, since the loading bar will be able to stretch the whole screen width (up to the 3-button navigation) again.
Additionally it would be cool if you could also add the window insets padding to the FloatingActionButton in SubscriptionsScreen as that one seems to go below the 3-button navigation in landscape mode.
Again, thanks for the help. We appreciate it!