Chris A.

Results 150 comments of Chris A.

Based on http://www.reddit.com/r/haskell/comments/2o5558/is_network_library_poorly_implemented_or_am_i/ It seems to me like if somebody PRs the safer functions as new functions, not changing the originals, it'll get accepted.

I've pushed a cleaned up version here that should be fine.

@AugustoFKL I'm not sure if you're addressing me but: >possible to do that with MySQL dialect? >Any reason why you're not willing to do so? Because it doesn't work. I'm...

>I believed one would have to fork the library anyway (or to upstream their dialect) in order to implement a useful custom dialect. This is helpful information and makes sense...

>I'll clean up this patch: https://github.com/sqlparser-rs/sqlparser-rs/pull/652 It's cleaned up now.

Buhhhh forgot to `cargo fmt` again, force-pushed an amended commit for this.

Switched the match expression to `matches!` because clippy bullied me.

Removed `#[must_use]` from the peek helper I wrote and lifted the backtick acceptance out of the trait default to GenericDialect. Tests still passed.

Please fix this before pushing to Hackage please.

I don't have any updates in this moment but I could take a pass at getting something in a mergeable state. You're lucky you pinged me at the beginning of...