bitcoin icon indicating copy to clipboard operation
bitcoin copied to clipboard

guix: consolidate to glibc 2.27 for Linux builds

Open fanquake opened this issue 2 years ago • 3 comments

Build against glibc 2.27 for all Linux builds (previously only used for RISC-V), and at the same time, increase our minimum required glibc to 2.27 (2018). This would drop support for Ubuntu Xenial (16.04) & Debian Stretch (9).

fanquake avatar Feb 02 '23 16:02 fanquake

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #25573 ([POC] guix: produce a fully -static-pie x86_64 bitcoind using GCC and glibc by fanquake)
  • #24123 (build: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix) by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot avatar Feb 02 '23 16:02 DrahtBot

For reference, this would affect less than 2% of snap users:

stats_feb2

maflcko avatar Feb 02 '23 17:02 maflcko

This would drop support for Ubuntu Xenial (16.04) & Debian Stretch (9).

Only for the binaries, right? Building from source should still be possible, I'd expect. (Though I'm not sure if we care, it might be good to clarify in the description)

luke-jr avatar Feb 06 '23 18:02 luke-jr

(Though I'm not sure if we care, it might be good to clarify in the description)

Added a note to the PR description.

fanquake avatar Feb 07 '23 13:02 fanquake

Concept ACK.

hebasto avatar Feb 07 '23 14:02 hebasto

Guix builds:

380420dbd00aa112f988bc7ab7e226f0662499d2008582bf325f47cc1a02a54d  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/SHA256SUMS.part
e2b77aaac9a2fd67a8b66892083802b28163b97906efc352d98b03d43f8371ab  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/bitcoin-d1c8711d8a17-aarch64-linux-gnu-debug.tar.gz
fec876f1039980d1706d938d2255d57ca6dd26163d4a31bee1704a0b7ebf90c6  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/bitcoin-d1c8711d8a17-aarch64-linux-gnu.tar.gz
acaaf65a53ebe2259256c2f1bd01c818a8e5ae1b7d68b9e8c90505a5ca8496e5  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/SHA256SUMS.part
9e88984b59284375590f6a58d91c6656bc01a3144ecf1f68b4745e2d47e26e14  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/bitcoin-d1c8711d8a17-arm-linux-gnueabihf-debug.tar.gz
11bff60d541ccc8d397d05af90e425b0e29732f6dbc339343a0e7d1ac65f0968  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/bitcoin-d1c8711d8a17-arm-linux-gnueabihf.tar.gz
993e2493c407ea8c7dd5fccc98c849467b967001b4a1151d43c570bf767bc9bb  guix-build-d1c8711d8a17/output/arm64-apple-darwin/SHA256SUMS.part
bbe0c2faba5fccfccced9e888edad57c45fa6a7ee96e0d823186556f2ebf737f  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin-unsigned.dmg
ecbab86e1b70c66aae0cfc6591a47fa2ae478238ee0a5ca2506fbac653fee39b  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin-unsigned.tar.gz
f6c2410e5fd357b0f5c0ab46bc507904bd1ba31b1b2cfe8f183c21f20e2876dc  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin.tar.gz
9c395364e92ff5489a51aab82b5630b578391549bba6f3d82f6ca4b03171d6db  guix-build-d1c8711d8a17/output/dist-archive/bitcoin-d1c8711d8a17.tar.gz
bd759857b26d0327e526efce9b6a5a93b12b427d2d948c9c16d363685bc565c4  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/SHA256SUMS.part
e7cb396838cb16b450c6610731081f4796fc32bbe950a47362b122e318a67109  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/bitcoin-d1c8711d8a17-powerpc64-linux-gnu-debug.tar.gz
f0cebc830796a431aa61fc92bfa49e4202d04cbfb5a4dad387e98de8beb12149  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/bitcoin-d1c8711d8a17-powerpc64-linux-gnu.tar.gz
6ec3fb20feb1ec195a0c875b881460f077d75ee9c76a84ff4e8ba5ab3f7a3a04  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/SHA256SUMS.part
c3bd6420a515f7a78a28b8556d017dc780c87b264d1709e68125fe5e416eaab7  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/bitcoin-d1c8711d8a17-powerpc64le-linux-gnu-debug.tar.gz
86a65f451ff949a35a15cbd6f6044b2da02c6c9ffb6a01b2115d676e5a1a2e2e  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/bitcoin-d1c8711d8a17-powerpc64le-linux-gnu.tar.gz
2176716c09834e4ed1d64a9c5a7bc027a2ac7ad24282d225d938fcddacee7363  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/SHA256SUMS.part
6f6f8855b06e907d62d5e514d9346cb9808a9168287fca4967d19bec6a04a0ee  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/bitcoin-d1c8711d8a17-riscv64-linux-gnu-debug.tar.gz
05dd291d58124f077df1308be7248e17421ca21139a7e0aae3ca55a7d7036e55  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/bitcoin-d1c8711d8a17-riscv64-linux-gnu.tar.gz
261bd1364f4c27c0f7ed3e6e2a47d1cc80b816cacc18bb5eaccb86925db055f0  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/SHA256SUMS.part
4fd7bd4fced41f4a24411bbaf8547e0ffede07dcb3099ae405f637abce9a4b62  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin-unsigned.dmg
51f93649501ffb4ad4aa8319a2554fb7241203472daae3589f6a1cd7d885b538  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin-unsigned.tar.gz
edd5aaa6c9584a2dedf95616ca9bdd52ae2a348e77270bfdc1e12066da1c4d08  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin.tar.gz
aef791b30bb3f4aa1998e50eff824a9ff3249b1e840405dcbc7d8af6a2253487  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/SHA256SUMS.part
b6c632ab1f667edb0e207f6692472207fbcaf8f8c2fae0369d8c1542ea981b02  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/bitcoin-d1c8711d8a17-x86_64-linux-gnu-debug.tar.gz
beea28998bd5d0e7b9984887bf5755e89d5b5e1ff1f84c05919520f72b1d115a  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/bitcoin-d1c8711d8a17-x86_64-linux-gnu.tar.gz
a0a2515afe79a7afb0f09ed10a03d3e30eb3185a4eeb7e26b833bd4f70cbbea9  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/SHA256SUMS.part
6aff5418a3a8b489ae4306619f459dce895095a792cb8a7e910e4c3d79552d71  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-debug.zip
34a32080c0f2ad2cb19c8bf0ef454fe3a745a746b68ff1dfcd5fe54fa8bc2188  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-setup-unsigned.exe
580ac9aa16c39341d6b8484cf73dd7c7f9b881e0dc17fd2c307f0e141fd59807  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-unsigned.tar.gz
7ca12110fd33cedd661ac9336243465c3dfef23d398228a60e91746b255e32ed  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64.zip

hebasto avatar Feb 10 '23 13:02 hebasto

Guix builds

File commit 8126551d54ffd290ed5767248be4b3d19243787b
(master)
commit 957f75a3da9a8fcf9f3a6058b4f13a646150554d
(master and this pull)
SHA256SUMS.part a73068811366a45b... 0feb34932bab5047...
*-aarch64-linux-gnu-debug.tar.gz 7d6dbd46fe457676... dd699b9597abbd1d...
*-aarch64-linux-gnu.tar.gz 7520e7a059cc6684... a46ee1d8481c1378...
*-arm-linux-gnueabihf-debug.tar.gz d97bb1418d3b2316... 78a659fa032201c8...
*-arm-linux-gnueabihf.tar.gz a1f0448968727793... 2346a7c7c19f7d08...
*-arm64-apple-darwin-unsigned.dmg 19533f717272f916... c84e24017cfdd259...
*-arm64-apple-darwin-unsigned.tar.gz 57aff0ec6005a6db... 6a9d56a52e60ea87...
*-arm64-apple-darwin.tar.gz 862c6afeee71f8fb... e9922cb5c63d7b3e...
*-powerpc64-linux-gnu-debug.tar.gz 4b643f0b06967242... 5c3881c39a9705c5...
*-powerpc64-linux-gnu.tar.gz 2670bee5edf6c3b8... a70ff0cc80d1192f...
*-powerpc64le-linux-gnu-debug.tar.gz 6270c7d026c419f7... bba55696abbf1cf0...
*-powerpc64le-linux-gnu.tar.gz e3e4232270ff5aef... bfde6ce9d895a8dc...
*-riscv64-linux-gnu-debug.tar.gz f40af1d070e277c7... 4a0178ad468c88c3...
*-riscv64-linux-gnu.tar.gz 110762f167d43d69... 68bb2cd75fb79e39...
*-win64-debug.zip 4ac7737d97907d51... 08ae361ea1f0a8aa...
*-win64-setup-unsigned.exe 859d32a0947d4da7... 8145dca946e90d63...
*-win64-unsigned.tar.gz f43a32fecc0c1eee... 35dbfa54222ab803...
*-win64.zip 1cdb7f63ef9f70b2... 44c396b62f77af23...
*-x86_64-apple-darwin-unsigned.dmg 034a7debb3f5adbf... 89fb30f742f9016d...
*-x86_64-apple-darwin-unsigned.tar.gz f441fb040d56859a... bcf003d38d1fcb65...
*-x86_64-apple-darwin.tar.gz 79b5f8787c6a3720... fda1b1140a7cc4da...
*-x86_64-linux-gnu-debug.tar.gz e2dc9354ef2e4819... f48883fe397b5f60...
*-x86_64-linux-gnu.tar.gz 185e3a914236c77c... b2cc85a3bb95edb9...
*.tar.gz 3daf687b07d336f1... ceff29304bb13ee7...
guix_build.log 57232e42a42fca6d... 7c14bdc95c329da0...
guix_build.log.diff 9651c6ad07fd1455...

DrahtBot avatar Feb 14 '23 08:02 DrahtBot

Guix builds:

851f4116c395a6b89475871a9763a111abad3951424276135931d80b1c09615e  guix-build-d5d4b75840b4/output/aarch64-linux-gnu/SHA256SUMS.part
bb9d3867b8f7dae5f9f8c326aa1b0e9fa28964659b3c7187e743152044c9dbe8  guix-build-d5d4b75840b4/output/aarch64-linux-gnu/bitcoin-d5d4b75840b4-aarch64-linux-gnu-debug.tar.gz
e4c0ab4883993362aea104ea776102a5d5beaa39a22e9aa22fd27a81d36415dc  guix-build-d5d4b75840b4/output/aarch64-linux-gnu/bitcoin-d5d4b75840b4-aarch64-linux-gnu.tar.gz
01b239015610aea0c4767f05f0222d06a6d99a9e5f92556a381274125c6d66a8  guix-build-d5d4b75840b4/output/arm-linux-gnueabihf/SHA256SUMS.part
e804a1c26a10968002ca0cb2014ff88c7ec537d000f0dbc860aae808bff6f450  guix-build-d5d4b75840b4/output/arm-linux-gnueabihf/bitcoin-d5d4b75840b4-arm-linux-gnueabihf-debug.tar.gz
e8e3bc689ed683ff8df9d6774e87fe16ff67b4ed1a74388b628a59a4ef487e5e  guix-build-d5d4b75840b4/output/arm-linux-gnueabihf/bitcoin-d5d4b75840b4-arm-linux-gnueabihf.tar.gz
d575b2a4eb2775442215f51e6a93ce074c1c115560bd4341cc70a7406345fe41  guix-build-d5d4b75840b4/output/arm64-apple-darwin/SHA256SUMS.part
49e2ad01a1eb9b8862546676d97a8440a64a90b2422f2fe600d25eb1006a1e8e  guix-build-d5d4b75840b4/output/arm64-apple-darwin/bitcoin-d5d4b75840b4-arm64-apple-darwin-unsigned.dmg
d244822ad0b5f766cb1a834676a482fc9927dea49c105da2ac61327c4ed658aa  guix-build-d5d4b75840b4/output/arm64-apple-darwin/bitcoin-d5d4b75840b4-arm64-apple-darwin-unsigned.tar.gz
fa2828d641e8e252d3988dff1ebcef65ce6a998a24c0508b533fb07637671c72  guix-build-d5d4b75840b4/output/arm64-apple-darwin/bitcoin-d5d4b75840b4-arm64-apple-darwin.tar.gz
d46fdade6a94cf9ebeb09fc7a5505e9778aa580eb5be83445f3a969dec7e585f  guix-build-d5d4b75840b4/output/dist-archive/bitcoin-d5d4b75840b4.tar.gz
fcf67a8fdb1985c7cff9770a18c32d83793af254dbb64589a3da52e0399949b3  guix-build-d5d4b75840b4/output/powerpc64-linux-gnu/SHA256SUMS.part
91aa7d168ad8f7a997d278c6834b7783e7e3e5e8d8fbc1a82d055dd1f2ff2721  guix-build-d5d4b75840b4/output/powerpc64-linux-gnu/bitcoin-d5d4b75840b4-powerpc64-linux-gnu-debug.tar.gz
30829f413c94c304432a0f5cbbc35765e5361df90044a2cb53b6aabd5b510e2e  guix-build-d5d4b75840b4/output/powerpc64-linux-gnu/bitcoin-d5d4b75840b4-powerpc64-linux-gnu.tar.gz
aa6769922b749214879a17b1ed1de2d7d320c9e41393315043851a89d15663ab  guix-build-d5d4b75840b4/output/powerpc64le-linux-gnu/SHA256SUMS.part
1e9ffb7fd8bdf98c9e67b70c1b93923e15b710c46337ce4c99bb7b3daf09470a  guix-build-d5d4b75840b4/output/powerpc64le-linux-gnu/bitcoin-d5d4b75840b4-powerpc64le-linux-gnu-debug.tar.gz
9def5193a9d7d68692775674309f9d9845beda30cf8063a24b9b8973a861f269  guix-build-d5d4b75840b4/output/powerpc64le-linux-gnu/bitcoin-d5d4b75840b4-powerpc64le-linux-gnu.tar.gz
c0b222629fea85695928dbd16e5c0e72c79696900a0146c40042322f2f01814f  guix-build-d5d4b75840b4/output/riscv64-linux-gnu/SHA256SUMS.part
4df06befb42b863bd95c1f8a4eb20e17301b09c13d86ebbe1ba7955e2a8fe6bc  guix-build-d5d4b75840b4/output/riscv64-linux-gnu/bitcoin-d5d4b75840b4-riscv64-linux-gnu-debug.tar.gz
b7fea7a60658295c2f4474041a79ea1e26761616edc37e89ab98d9805f1886a4  guix-build-d5d4b75840b4/output/riscv64-linux-gnu/bitcoin-d5d4b75840b4-riscv64-linux-gnu.tar.gz
48e84106393c6f1b289fe2e0df313bfa7a42b2f3b896b291e41dcf002da31c9f  guix-build-d5d4b75840b4/output/x86_64-apple-darwin/SHA256SUMS.part
c4dca1fbe3ff37f6a04987e064ac8a6decdba2982553f8bbbccc3d5aaeb78ef2  guix-build-d5d4b75840b4/output/x86_64-apple-darwin/bitcoin-d5d4b75840b4-x86_64-apple-darwin-unsigned.dmg
753214c4afd588e3e667f29e14d21994549b26f0e1e2128d5a9e7010f3a07011  guix-build-d5d4b75840b4/output/x86_64-apple-darwin/bitcoin-d5d4b75840b4-x86_64-apple-darwin-unsigned.tar.gz
4b8d9cb9d23bde32093a21b5b7faddd8b5ef7bbf5a30337168bb4d444ddd1ac5  guix-build-d5d4b75840b4/output/x86_64-apple-darwin/bitcoin-d5d4b75840b4-x86_64-apple-darwin.tar.gz
2da36961e66d3c187f8ac528b5071f32dd411297da832bd30d0d824ada33ba03  guix-build-d5d4b75840b4/output/x86_64-linux-gnu/SHA256SUMS.part
55c26b8cdac8dc858700719b4a6f7b9da7da3c433c66332acb0ac13070bcbf1f  guix-build-d5d4b75840b4/output/x86_64-linux-gnu/bitcoin-d5d4b75840b4-x86_64-linux-gnu-debug.tar.gz
9fed647746e45b19cc34c1f92e9f0690362b994a806a9278c569854ad8058d89  guix-build-d5d4b75840b4/output/x86_64-linux-gnu/bitcoin-d5d4b75840b4-x86_64-linux-gnu.tar.gz
058d79d1865dfe7f7ae45b9d12c5fa2edf4c00fedfabfbb3d16d0e4b6c65be6a  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/SHA256SUMS.part
87f43c510ad32405aa70c7d26facd01cb865068f72f8c6025748ef9b991c21fb  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/bitcoin-d5d4b75840b4-win64-debug.zip
d14ebf78778522b79abdbd19451ff2326452e909a4223ea31d964b0e231d29c4  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/bitcoin-d5d4b75840b4-win64-setup-unsigned.exe
91e6baa2f53f86d3835e730d82dde8a760bcdf91c3d9c2501ab4714e518c3123  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/bitcoin-d5d4b75840b4-win64-unsigned.tar.gz
38355434457d7d4fd64e771b62f1033f53bb3f3346197b0ffaafab270fdf37e6  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/bitcoin-d5d4b75840b4-win64.zip

hebasto avatar Feb 14 '23 12:02 hebasto