bips icon indicating copy to clipboard operation
bips copied to clipboard

update bip0129 to reduce ambiguity

Open instagibbs opened this issue 4 years ago • 2 comments
trafficstars

I read it as "both types accepted" and couldn't find the definition of the signature format for non-p2pkh scripts, leading me to reread this section again after reading the BIP322. I think this is clearer, and if I'm wrong, it definitely needs a boost.

instagibbs avatar Sep 23 '21 06:09 instagibbs

@hugohn

luke-jr avatar Nov 04 '21 22:11 luke-jr

Oops sorry I missed this. Thanks @luke-jr !

@instagibbs The idea was that I wanted to make BIP-0129 future-proof. Non-legacy BIP-0322 signatures would be ideal because those signatures actually commit to the XPUBs listed in the BSMS file. When BIP-0322 is ready we could just switch to the new signature type without having to update BIP-0129. But yeah BIP-0322 is still incomplete at the moment.

hugohn avatar Nov 05 '21 00:11 hugohn

@hugohn, @instagibbs: Could you perhaps clarify the status of this PR?

murchandamus avatar Apr 26 '24 19:04 murchandamus

I don't remember this :)

instagibbs avatar Apr 26 '24 19:04 instagibbs

I suppose that is meant to mean that you no longer seek to get this merged?

Will close after 2024-05-10 unless I hear otherwise.

murchandamus avatar Apr 26 '24 20:04 murchandamus

@hugohn can open another if he understands it

instagibbs avatar Apr 26 '24 21:04 instagibbs