gui
gui copied to clipboard
bitcoin-core
Add used balance to overview page
Second part: Fixes https://github.com/bitcoin-core/gui/issues/769
Add used balance to the overview page for wallets with the avoid_reuse flag enabled
Prerequsite:
- Part one (should be merged first): https://github.com/bitcoin/bitcoin/pull/28776
overview page when avoid_reuse is enabled
overview page when avoid_reuse is not enabled
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept ACK | katesalazar, pablomartin4btc |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
@BrandonOdiwuor
Second part: Fixes #769
Add used balance to the overview page for wallets with the avoid_reuse flag enabled
Prerequsite:
- Part one (should be merged first): Wallet: Functions to enable adding used balance to GUI overview page bitcoin/bitcoin#28776
If you are still working on this PR, please address https://github.com/bitcoin/bitcoin/pull/28776#discussion_r1557805199.
@hebasto Sorry I will be updating the PR description
There was a change in implementation. I created a different PR (https://github.com/bitcoin/bitcoin/pull/29062) based on the recommendation to refactor the getbalance() function which touches the bitcoin repo. trying to get it merged so that I can update this PR
There was a change in implementation. I created a different PR (bitcoin/bitcoin#29062) based on the recommendation to refactor the
getbalance()function which touches the bitcoin repo. trying to get it merged so that I can update this PR
Okay. Until then, marking this PR as a draft.