Fix transaction view/table

[luke-jr]

#204 reverted a necessary bugfix, and #205 introduced regressions since setModel resets column widths. Note that you need to delete your saved GUI config to see the fix, otherwise the prior widths are restored.

Before regressions:

After regressions / current master:

With this PR:

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #684 (Improve 'Requested Payments History' Multiselect by john-moffett)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[luke-jr]

if we revert the PR's aren't we still left with a buggy transaction table?

I'm not aware of any documented bugs. With the PRs reverted, it works perfect for me.

Additionally, it's possible that the class mentioned can lead to a segfault when loading in a very large wallet:

These bugs seem outside the scope of this PR, but if you can explain, I can try to take a shot at fixing them?

[hebasto]

From PR description it is not clear what actual bug this PR is supposed to fix.

#204 reverted a necessary bugfix,

Wrong. See #204 PR description.

and https://github.com/bitcoin-core/gui/pull/205 introduced regressions since setModel resets column widths.

Wrong. Column widths belong to a "View" layer. A "Model" layer should do nothing with a visual representation. It is up to user to set the "View" layer, including column widths.

[luke-jr]

Not wrong. See screenshots.

[hebasto]

Closing due to a long period of inactivity here. Feel free to reopen.

[achow101]

Reopening was requested.

[luke-jr]

Re-confirmed bug still exists, and rebased this fix.

[hebasto]

Tested 8e428cc1188568aaeeaeb8f1f4498ae5b738a5e2 on Ubuntu 23.04.

Application window resizing leads to:

when the content of the last column "Amount" goes out of the scope.

[maflcko]

From CI:

./qt/receivecoinsdialog.h:54:48: error: use default member initializer for 'columnResizingFixer' [modernize-use-default-member-init,-warnings-as-errors]
    GUIUtil::TableViewLastColumnResizingFixer *columnResizingFixer;
                                               ^
                                                                  {nullptr}

[DrahtBot]

🤔 There hasn't been much activity lately and the CI seems to be failing.

If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

[hebasto]

Closing due to lack of support from the PR author (unaddressed comments, the failed CI).