gui
gui copied to clipboard
bitcoin-core
Enable users to configure their monospace font specifically
This replaces the overly-verbose radio-button font setting (which only allows embedded or autodetected from system) with a simple combobox providing both existing options as well as a custom option to allow the user to select any font of their choice/style.
a follow-up can be to use the selected font wherever monospace fonts are used such as the console.
A separate configuration for that may make sense , but yes, this makes it much simpler to do that. Figured it would be a bit too much for this PR though :)
Concept ACK
This should allow users to select a dyslexic font as well (if they have it installed) - which can be helpful when dealing with numbers.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept ACK | jarolrod, promag, RandyMcMillan |
| Approach ACK | hebasto |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #603 (Add settings.json prune-prev, proxy-prev, onion-prev settings by ryanofsky)
- #bitcoin/bitcoin/25386 (refactor: Extract MIB_BYTES constant for init.cpp by Empact)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".
Approach ACK. Tested on Windows 11. Observing kind of jittering of the vertical position of the "Font in the Overview tab:" label when choosing different fonts. Could it be avoided?
I'm guessing it's the preview font changing? How would you suggest avoiding it?