gui-qml
gui-qml copied to clipboard
Add PeerDetails page [Alternative]
Alternative to https://github.com/bitcoin-core/gui-qml/pull/387 which expands to think about a reusable row component, allowing to load any element(s) to the value field, not hardcoding in a height of 21 for a row (but still ensuring it's a minimum of 21), proper icon usage for N/A cases, dummy net indicators in place
TODO:
- Ban buttons
- Hover hints
- Disconnected state instead of flying back to the peers table
- Smart text fixups
Link to github actions build artifacts.
draft until I fix the line spacing when text wraps
Updated from 4909ba5 to 02d3121
Addressed review comments on id naming and icon size, additionally rebased over main to address conflicts. TODO's to be left for follow-ups
CI reports a linker error on macOS 13:
ld: Undefined symbols:
qInitResources_bitcoin_qml(), referenced from:
QmlGuiMain(int, char**) in libbitcoinqt.a[60](qt_libbitcoinqt_a-bitcoin.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
CI reports a linker error on macOS 13:
ld: Undefined symbols: qInitResources_bitcoin_qml(), referenced from: QmlGuiMain(int, char**) in libbitcoinqt.a[60](qt_libbitcoinqt_a-bitcoin.o) clang: error: linker command failed with exit code 1 (use -v to see invocation)
Fixed in https://github.com/bitcoin-core/gui-qml/pull/425.