gui-qml icon indicating copy to clipboard operation
gui-qml copied to clipboard

Add PeerDetails page [Alternative]

Open jarolrod opened this issue 1 year ago • 1 comments

Alternative to https://github.com/bitcoin-core/gui-qml/pull/387 which expands to think about a reusable row component, allowing to load any element(s) to the value field, not hardcoding in a height of 21 for a row (but still ensuring it's a minimum of 21), proper icon usage for N/A cases, dummy net indicators in place

TODO:

  • Ban buttons
  • Hover hints
  • Disconnected state instead of flying back to the peers table
  • Smart text fixups
Screenshot 2024-02-28 at 3 53 43 AM

Link to github actions build artifacts.

Build Artifacts

jarolrod avatar Feb 28 '24 09:02 jarolrod

draft until I fix the line spacing when text wraps

jarolrod avatar Mar 20 '24 08:03 jarolrod

Updated from 4909ba5 to 02d3121

Addressed review comments on id naming and icon size, additionally rebased over main to address conflicts. TODO's to be left for follow-ups

jarolrod avatar Sep 25 '24 11:09 jarolrod

CI reports a linker error on macOS 13:

ld: Undefined symbols:
  qInitResources_bitcoin_qml(), referenced from:
      QmlGuiMain(int, char**) in libbitcoinqt.a[60](qt_libbitcoinqt_a-bitcoin.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

hebasto avatar Oct 12 '24 16:10 hebasto

CI reports a linker error on macOS 13:

ld: Undefined symbols:
  qInitResources_bitcoin_qml(), referenced from:
      QmlGuiMain(int, char**) in libbitcoinqt.a[60](qt_libbitcoinqt_a-bitcoin.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Fixed in https://github.com/bitcoin-core/gui-qml/pull/425.

hebasto avatar Oct 12 '24 17:10 hebasto