phpstan-magento icon indicating copy to clipboard operation
phpstan-magento copied to clipboard

Feature Request: GitHub Action for bitexpert/phpstan-magento

Open shochdoerfer opened this issue 4 years ago • 9 comments
trafficstars

Build a GitHub Action to let phpstan-magento run in GitHub build pipelines automatically. Check what the extdn people have done for their actions and adapt https://github.com/extdn/github-actions-m2

shochdoerfer avatar Dec 19 '20 13:12 shochdoerfer

@torhoehn did you hack on that during the Firegento Hackathon?

shochdoerfer avatar Feb 08 '21 10:02 shochdoerfer

@shochdoerfer No, I was a little bit late, so @frostblogNet proposed this topic. As I have arrived @schmengler looked for a partner, so we worked together on something else.

torhoehn avatar Feb 08 '21 10:02 torhoehn

No worries, just saw on Twitter that this topic was proposed. Wanted to avoid that we both work on this and no one is aware ;)

shochdoerfer avatar Feb 08 '21 10:02 shochdoerfer

@shochdoerfer Is this solved, because the repo already runs GitHub Actions or do you thinking about extending this?

torhoehn avatar Mar 16 '22 12:03 torhoehn

Not yet solved. The goal was to have GitHub Action with PHPStan and this extension so that others could run it easily in their GitHub CI pipeline. Similar to what the extdn are doing: https://github.com/extdn/github-actions-m2/tree/master/magento-phpstan

shochdoerfer avatar Mar 16 '22 12:03 shochdoerfer

Ah now I remember. While writing my previous comment I wasn't in the correct context.

torhoehn avatar Mar 16 '22 12:03 torhoehn

No worries, that happens ;) Still, if you feel, you wanna tackle it, let me know.

shochdoerfer avatar Mar 17 '22 16:03 shochdoerfer

Started yesterday to play around with it.

torhoehn avatar Mar 17 '22 16:03 torhoehn

It could be that it is possible to use the phpstan GitHub Action provided by the extdn people: https://github.com/extdn/github-actions-m2/tree/master/magento-phpstan

Check and document!

shochdoerfer avatar May 03 '22 12:05 shochdoerfer