orange-widget-base icon indicating copy to clipboard operation
orange-widget-base copied to clipboard

[FIX] widget: Make controlAreaVisible a global setting

Open ales-erjavec opened this issue 11 months ago • 2 comments

Issue

Make controlAreaVisible a global setting along the widget geometry.

Description of changes

Make controlAreaVisible a global setting

Includes
  • [X] Code changes
  • [ ] Tests
  • [ ] Documentation

ales-erjavec avatar Dec 13 '24 08:12 ales-erjavec

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.03%. Comparing base (c28fde3) to head (13e174b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   72.03%   72.03%           
=======================================
  Files          34       34           
  Lines        9117     9117           
=======================================
  Hits         6567     6567           
  Misses       2550     2550           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 13 '24 08:12 codecov-commenter

@ales-erjavec, thanks, this change means that now a newly added widget could be shown with a hidden control area. @janezd (and me) pointed out that for new widgets, the control area should always be shown. The size is problematic: if a default was saved with a hidden control area, the new widget size should be increased in width by the control area size.

markotoplak avatar Dec 13 '24 09:12 markotoplak