wasm-e2e icon indicating copy to clipboard operation
wasm-e2e copied to clipboard

Use the upstream V8 repo rather than v8-native-prototype.

Open ncbray opened this issue 9 years ago • 2 comments

Fixes #12

ncbray avatar Dec 14 '15 23:12 ncbray

@flagxor - thinking about this, should it be a git submodule or a pinned hash, ala LLVM? If it's a pinned hash, it would be easier to modulate between downloading binaries or building from source. Are we still planning to pull d8 binaries on the bots?

ncbray avatar Dec 15 '15 00:12 ncbray

As discussed offline with @ncbray I agree with him and think it's easier to have git hash: I'd rather use the submodule file format and switch from submodule sources to downloaded at will (the tool that gets binaries would just parse that file), but git submodule won't be happy with only a few of the submodules being initialized and the other being downloaded binaries. If we want to switch only some of the dependencies to binary during our workflow then submodules aren't a good fit.

jfbastien avatar Dec 15 '15 02:12 jfbastien