react-native-sse
react-native-sse copied to clipboard
binaryminds
Fix: Disable cache control and x formatted by header
@wojciechkrol @EmilJunker Thank you for the patience. Please review now.
@arpitmalik Your changes look good to me, although it's a bit difficult to review because of all the unrelated formatting changes you made. I must say that I'm not a big fan of stretching simple if conditions and function calls over multiple lines of code.
Please merge the code if it looks good. Formatting is done only to make the code readable.
Please merge the code if it looks good. Formatting is done only to make the code readable.
I guess formatting was automatically made by code editor plugins like prettier? I suggest leave these unrelated formatting untouched and obey the one-line condition rule on newly added lines as the author said, everyone have a different opinion on readable code, and you may not want him spend extra time on restoring code to how it looked before.
LGTM 👍
@wojciechkrol Can you please merge this as well as #63. Both of these pull requests would make great additions to this library.
@wojciechkrol Can you please merge both these on priority. Its been more than 3 months.
@wojciechkrol Please be active on this. Merge this pull request as soon as possible.