settingslogic icon indicating copy to clipboard operation
settingslogic copied to clipboard

Comaptibility with ruby 1.8.7

Open dush opened this issue 13 years ago • 5 comments

Settingslogic 2.0.7 is not comaptible with ruby 1.8.7 due to its dependency on ruby-debug19. There was

gem 'settingslogic', '~>2.0.6'

in my Gemfile. Then bundle failed

# bundle install
...
Gem::InstallError: linecache19 requires Ruby version >= 1.9.2.
An error occured while installing linecache19 (0.5.12), and Bundler cannot continue.
Make sure that `gem install linecache19 -v '0.5.12'` succeeds before bundling.

I think settingslogic should not depend on ruby-debug19 when using ruby 1.8.7. If there is any reason (other than ruby-debug19) settingslogic have become incompatible with ruby 1.8.7, than it's version should be bumped to 2.1.0 and keep branch 2.0.x compatible with 1.8.7.

dush avatar Jan 06 '12 13:01 dush

Another issue is that ruby-debug19 is a runtime dependency when it should be a development / test dependency.

rymai avatar Jan 06 '12 15:01 rymai

I'm working on a quick fix for this, unless Ben has time.

wpeterson avatar Jan 06 '12 16:01 wpeterson

Potential fix submitted in pull request here:

https://github.com/binarylogic/settingslogic/pull/29

wpeterson avatar Jan 06 '12 16:01 wpeterson

This should be fixed in 2.0.8

wpeterson avatar Jan 10 '12 15:01 wpeterson

@dush @wpeterson I think it's safe to close this issue now. :)

Cheers!

rymai avatar Dec 21 '13 12:12 rymai