stencil-cli icon indicating copy to clipboard operation
stencil-cli copied to clipboard

stencil download pull command corrupts image assets

Open thenapoleon opened this issue 4 years ago • 6 comments

stencil version: 3.0.3 macbook

Expected behavior

when executing stencil download or pull, I would expect the image assets to be downloaded and saved in their correct format.

Actual behavior

when downloaded the assets are corrupted which leads to broken images onto live sites when the site is pushed.

Steps to reproduce behavior

stencil init stencil donwload

check asset folder containing images, and see that images are corrupted.

Screenshot 2020-12-06 at 16 15 01

note: if we download the theme from BigCommerce website storefront admin, the images are downloaded correctly. This only seems to happen when using stencil.

thenapoleon avatar Dec 06 '20 16:12 thenapoleon

@thenapoleon Thanks for your report. I managed to reproduce the issue and created a corresponding ticket (STRF-8865) on our internal board to fix the bug.

MaxGenash avatar Dec 14 '20 12:12 MaxGenash

@MaxGenash Thank you and very much appreciated.

thenapoleon avatar Dec 14 '20 13:12 thenapoleon

@thenapoleon Thank you for reporting this.

@MaxGenash Any solution or workaround?

I'm having the exact same issue. It looks like I'm going to need to download the theme files from BigCommerce website storefront admin as well.

carlosbensant avatar Jan 22 '21 12:01 carlosbensant

@carlosbensant for now I downloaded the assets manually and copied them into my repository. The upload doesn't seem to corrupt these images, only the download.

I see that there is a new release of stencil, @MaxGenash, is the fix included in that release?

yoanne2x avatar Jan 22 '21 12:01 yoanne2x

The fix for this issue is not ready yet, we were busy with other higher-priority stuff. Meanwhile, as a temporary workaround, you can download the assets manually, or try [email protected]

MaxGenash avatar Feb 05 '21 17:02 MaxGenash

@thenapoleon @carlosbensant @caas-e2x

This issue was fixed in #685 and released as v3.1.1 to NPM. Please, retry with the updated version of stencil-cli.

MaxGenash avatar Mar 11 '21 12:03 MaxGenash