bigbluebutton-api-php icon indicating copy to clipboard operation
bigbluebutton-api-php copied to clipboard

Use strlen instead of mb_strlen

Open Ezanor opened this issue 5 years ago • 1 comments

Hi,

Is there any reason to use mb_strlen instead of strlen for the Content-Length header here : https://github.com/bigbluebutton/bigbluebutton-api-php/blob/48aa35340213fd3a6f3d6d81eb54d7b4eebef141/src/BigBlueButton.php#L475

mb_strlen get number of char VS strlen get the number of octets.

I just found that pre-uploading multiple pdf with some char cause bbb-web to stop reading body before the closing tag of the module presentation. And the create request fail.

Ezanor avatar Jul 30 '20 13:07 Ezanor

@Ezanor Can you please provide more information?

GhaziTriki avatar Apr 23 '24 08:04 GhaziTriki

More info here https://www.rfc-editor.org/rfc/rfc9110.html#section-8.6

GhaziTriki avatar May 01 '24 16:05 GhaziTriki

Fixed in https://github.com/bigbluebutton/bigbluebutton-api-php/commit/3fcfbd6e7a29d49b763405c6cdfd4918dd80bfc7

GhaziTriki avatar May 01 '24 17:05 GhaziTriki

Commit https://github.com/bigbluebutton/bigbluebutton-api-php/commit/3fcfbd6e7a29d49b763405c6cdfd4918dd80bfc7 not solving issue. cs-fixeris reverting strlen() back to mb_strlen()

DigitalTimK avatar May 06 '24 11:05 DigitalTimK