bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

deno: Does not ERROR on the unknown DatasetType + does not warn that no subjects

Open yarikoptic opened this issue 1 year ago • 0 comments

I am preparing example for the

  • https://github.com/bids-standard/bids-specification/pull/1861

and upon initial validation receiving NO error although it should be there since I entered (for extra check) a completely unknown value.

❯ bids-validator-deno --version
bids-validator v1.14.7-dev.0-68-g53fdba69

❯ grep DatasetType dataset_description.json
    "DatasetType": "prlkjasdfoject",
❯ bids-validator-deno $PWD
This dataset appears to be BIDS compatible.

          Summary:                         Available Tasks:        Available Modalities:
          1 Files, 336 B                                                                
          0 - Subjects 1 - Sessions                                                     

	If you have any questions, please post on https://neurostars.org/tags/bids.

❯ bids-validator $PWD

[email protected]
	1: [ERR] Invalid JSON file. The file is not formatted according the schema. (code: 55 - JSON_SCHEMA_VALIDATION_ERROR)
		./dataset_description.json
			Evidence: .DatasetType should be equal to one of the allowed values

	Please visit https://neurostars.org/search?q=JSON_SCHEMA_VALIDATION_ERROR for existing conversations about this issue.

	2: [ERR] There are no subject folders (labeled "sub-*") in the root of this dataset. (code: 45 - SUBJECT_FOLDERS)

	Please visit https://neurostars.org/search?q=SUBJECT_FOLDERS for existing conversations about this issue.

	1: [WARN] The recommended file /README is missing. See Section 03 (Modality agnostic files) of the BIDS specification. (code: 101 - README_FILE_MISSING)

	Please visit https://neurostars.org/search?q=README_FILE_MISSING for existing conversations about this issue.

        Summary:            Available Tasks:        Available Modalities: 
        1 File, 336B                                                      
        0 - Subjects                                                      
        1 - Session                                                       


	If you have any questions, please post on https://neurostars.org/tags/bids.

yarikoptic avatar Jun 22 '24 07:06 yarikoptic