bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

feat(py): Base Python validator on schema instead of hard-coded regexes

Open effigies opened this issue 1 year ago • 1 comments
trafficstars

With this PR, we can decouple the Python "validator" from the legacy validator, depending only on the schema.

Depends on bids-standard/bids-specification#1672 and #1957.

Closes https://github.com/bids-standard/bids-validator/issues/1821.

effigies avatar May 06 '24 18:05 effigies

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.68%. Comparing base (fffc35c) to head (f103ac2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1967   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          91       91           
  Lines        3792     3792           
  Branches     1220     1220           
=======================================
  Hits         3249     3249           
  Misses        457      457           
  Partials       86       86           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 18:05 codecov[bot]

@tsalo @Remi-Gau @sappelhoff If I could get a review from one of you on the Python, that would be greatly appreciated.

effigies avatar May 23 '24 15:05 effigies