[ENH] add support for qMRI json in top dir

[Remi-Gau]

relates to #1438

[codecov[bot]]

Codecov Report

Base: 83.27% // Head: 83.17% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (ba1f53a) compared to base (596bb07). Patch coverage: 66.66% of modified lines in pull request are covered.

:exclamation: Current head ba1f53a differs from pull request most recent head 7e8e846. Consider uploading reports for the commit 7e8e846 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1546      +/-   ##
==========================================
- Coverage   83.27%   83.17%   -0.10%     
==========================================
  Files          91       91              
  Lines        3742     3763      +21     
  Branches     1144     1158      +14     
==========================================
+ Hits         3116     3130      +14     
- Misses        528      535       +7     
  Partials       98       98              

Impacted Files	Coverage Δ
bids-validator/utils/type.js	88.59% <66.66%> (-1.67%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[Remi-Gau]

OK trying to test but I am failing to do it locally against this PR https://github.com/bids-standard/bids-examples/pull/337 of the bids-example

[rwblair]

@Remi-Gau each top rule still had one required entity, I made those all optional and removed the anat_top entries.

[Remi-Gau]

note to self: still getting an error for the MP2RAGE dataset

[Remi-Gau]

Note that maybe we may actually want to keep the required entities in the name.

For example, it seems that the validator does not accept a bare bold.json file in the root of the dataset: it requires the task entity in the filename.

[Remi-Gau]

partly related to https://github.com/bids-standard/bids-validator/issues/1631

[Remi-Gau]

Seems that all the modified datasets in the bids examples are not OK with this.

Thanks @rwblair

Merge whenever you want

[bpinsard]

The error is still present for *UNIT1.json files, was there any reason it was not integrated in this PR? This causes pybids.BIDSLayout.build_path to fail. :-/

[effigies]

No. Can you open a PR?

I started a bit back on basing the Python validator on the schema, which should make it less susceptible to these errors of omission. I got stalled by https://github.com/bids-standard/bids-specification/pull/1672.