bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

Update regexp for blood pet to require the recording entity

Open mnoergaard opened this issue 3 years ago • 1 comments

This PR updates the regexp for blood pet data to have the recording entity required in the filename if blood data is present (https://github.com/bids-standard/bids-validator/issues/1499#issue-1336399775). The update is also in line with https://github.com/bids-standard/bids-specification/pull/1005/files, where I failed to identify an update to the validator back then.

mnoergaard avatar Aug 11 '22 21:08 mnoergaard

Codecov Report

Merging #1500 (1b3761f) into master (d96d6ff) will decrease coverage by 1.99%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   85.26%   83.26%   -2.00%     
==========================================
  Files          91       93       +2     
  Lines        3699     4040     +341     
  Branches     1127     1308     +181     
==========================================
+ Hits         3154     3364     +210     
- Misses        458      537      +79     
- Partials       87      139      +52     
Impacted Files Coverage Δ
...ids-validator/validators/tsv/validateTsvColumns.js 45.45% <0.00%> (-7.11%) :arrow_down:
bids-validator/utils/issues/index.js 77.35% <0.00%> (-2.19%) :arrow_down:
bids-validator/utils/files/readDir.js 77.65% <0.00%> (-0.42%) :arrow_down:
bids-validator/utils/files/illegalCharacterTest.js 100.00% <0.00%> (ø)
...dator/validators/nifti/fieldmapWithoutMagnitude.js 100.00% <0.00%> (ø)
bids-validator/validators/schemaTypes.js 3.70% <0.00%> (ø)
bids-validator/validators/options.js 100.00% <0.00%> (ø)
bids-validator/validators/tsv/validate.js 95.65% <0.00%> (+0.19%) :arrow_up:
bids-validator/utils/bids_files.js 90.90% <0.00%> (+0.58%) :arrow_up:
bids-validator/validators/bids/quickTestError.js 94.11% <0.00%> (+0.78%) :arrow_up:
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 11 '22 22:08 codecov[bot]

  • ?: starts a non-capturing group, which for how we use regex right now may not be necessary
  • the ? at the end of the capture group parentheses is what makes the group optional or required.

rwblair avatar Aug 23 '22 16:08 rwblair

@mnoergaard does this fix work on your data as expected?

sappelhoff avatar Aug 25 '22 10:08 sappelhoff

tested locally and it works.

rwblair avatar Aug 31 '22 15:08 rwblair

Thank you @rwblair and @sappelhoff !

mnoergaard avatar Aug 31 '22 15:08 mnoergaard