bids-specification icon indicating copy to clipboard operation
bids-specification copied to clipboard

[ENH] Add support for HiP-CT

Open balbasty opened this issue 1 year ago • 5 comments

Resolves: #1646

This PR introduces a new hipCT microscopy suffix.

It does not make any changes to the required or optional metadata. To me, HiP-CT is not a quantitative modality, so I do not see any parameters that would be required for downstream analysis. Please give feedback if you feel that this is not correct and that hip-ct-specific metadata should be added.

I am leaving it as a draft PR for now.

cc @satra @ucbpclw

balbasty avatar Jan 24 '24 16:01 balbasty

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (327bece) to head (cfe7ac1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1686   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 24 '24 16:01 codecov[bot]

This seems fine to me, and there were no objections on the discussion #1646.

@jcohenadad Do you see any problems with this?

effigies avatar Feb 16 '24 18:02 effigies

@jcohenadad Do you see any problems with this?

on the contrary, this is a great addition!

jcohenadad avatar Feb 16 '24 18:02 jcohenadad

Thanks! I removed the draft mode

balbasty avatar Feb 16 '24 18:02 balbasty

Note that by the rules we do need a second approving review by a community member. (It does not need to be a maintainer.)

effigies avatar Mar 08 '24 16:03 effigies