Add reflection support for VecDeque

Open ItsDoot opened this issue 3 years ago • 9 comments

Objective

Fixes #5791

Solution

Implemented all the required reflection traits for VecDeque, taking from Vec's impls.

Aug 25 '22 07:08 ItsDoot

Hm, this is an interesting one because it's a slightly different data structure. We sorta lose its usefulness (the queue properties) when reflecting, and we can only really get it back after casting back to its original type (or providing TypeData to use it).

Is it okay that we dumb all these structures down to their base types (List/Map)? Should they instead be considered Value types like HashSet? I think this is fine, but I'd like to hear if anyone has any other thoughts on this matter.

Aug 25 '22 16:08 MrGVSV

Is it okay that we dumb all these structures down to their base types (List/Map)? Should they instead be considered Value types like HashSet? I think this is fine, but I'd like to hear if anyone has any other thoughts on this matter.

Dumbing down is the "standard" way in my experience. The serde model also hints at that.