bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Published 20 hours ago • verified publisher icon bevyengine

Update web-time requirement from 0.2 to 1.0

Open dependabot[bot] opened this issue 1 year ago • 5 comments

Updates the requirements on web-time to permit the latest version.

Release notes

Sourced from web-time's releases.

V1 Release

Added

  • V1 release.
Changelog

Sourced from web-time's changelog.

[1.0.0] - 2024-01-14

Added

  • V1 release.

[0.2.4] - 2023-12-24

Added

  • Added web module containing a platform-specific extension trait to SystemTime, allowing conversion from and to std::time::SystemTime.

Changed

  • Improve performance of SystemTime by using Duration internally.

[0.2.3] - 2023-10-23

Changed

  • Improve accuracy of Instant::now().

[0.2.2] - 2023-10-08

Fixed

  • Time conversion for Instant.

[0.2.1] - 2023-10-07 [YANKED]

Changed

  • Bump MSRV to v1.60.

Removed

  • Unnecessary once_cell dependency.

[0.2.0] - 2023-03-28

Added

[0.1.0] - 2023-03-27

Added

  • Initial commit.

... (truncated)

Commits
  • 6431f16 Prepare new release
  • ac5bcf3 Fix doc linting
  • dca3d82 Use target_os = "unknown"
  • 2305125 Fix deployment URL
  • e8f0aac Prepare new release
  • 821a55d Show proper cfgs on documentation
  • 84d07ea Add SystemTimeExt
  • 1d43b5d Improve changelog internal readability
  • 8df95b9 Improve performance of SystemTime by using Duration internally
  • 77f6203 Fix wrong references to branch name
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Feb 05 '24 06:02 dependabot[bot]

Blocking this on a winit update so we can minimize our duplicate dependencies.

james7132 avatar Feb 06 '24 04:02 james7132

Hi, author here :wave:!

I think the library is just being stabilized.

Indeed.

Though I'm concerned about daxpedda/web-time@dca3d82.

Whats the concern here exactly?

web-time is duplicated, since winit depends on 0.2, which is why the CI is failing. rust-windowing/winit#3392 has been merged so that duplicate will be fixed soon, but for now this PR is blocked.

The problem will also be interoperability. E.g.ControlFlow::WaitUntil will be a bit tougher to work with if you don't use the same dependency version. So it should be perfectly fine to just wait for the next Winit release before updating.

daxpedda avatar Feb 06 '24 09:02 daxpedda

Though I'm concerned about daxpedda/web-time@dca3d82.

Whats the concern here exactly?

I just wasn't sure what that commit was doing. Could you give a small explanation? I don't know much about the cfg attributes that were modified.

web-time is duplicated, since winit depends on 0.2, which is why the CI is failing. rust-windowing/winit#3392 has been merged so that duplicate will be fixed soon, but for now this PR is blocked.

The problem will also be interoperability. E.g.ControlFlow::WaitUntil will be a bit tougher to work with if you don't use the same dependency version. So it should be perfectly fine to just wait for the next Winit release before updating.

Ok, sounds good.

BD103 avatar Feb 06 '24 13:02 BD103

Though I'm concerned about daxpedda/web-time@dca3d82.

Whats the concern here exactly?

I just wasn't sure what that commit was doing. Could you give a small explanation? I don't know much about the cfg attributes that were modified.

web-time targets the wasm32-unknown-unknown target exclusively. Ergo it does not target wasm32-unknown-emscripten or wasm32-wasi. The reason is that both those targets have their own working std::time implementation and don't require web-time in the first place.

Previously this was expressed as cfg(all(target_family = "wasm", not(any(target_os = "emscripten", target_os = "wasi")))), which basically says all Wasm targets that aren't Emscripten or Wasi.

daxpedda/web-time@dca3d82 changes this to cfg(all(target_family = "wasm", target_os = "unknown")), which says all Wasm targets that have an unknown target OS, which corresponds to wasm32-unknown-unknown exclusively.

This has no actual downstream effect, but it does protect against a potential new target, e.g. wasm32-unknown-newshinyos. For more on cfg in general see The Rust Reference.

daxpedda avatar Feb 06 '24 13:02 daxpedda

web-time targets the wasm32-unknown-unknown target exclusively. Ergo it does not target wasm32-unknown-emscripten or wasm32-wasi. The reason is that both those targets have their own working std::time implementation and don't require web-time in the first place.

Previously this was expressed as cfg(all(target_family = "wasm", not(any(target_os = "emscripten", target_os = "wasi")))), which basically says all Wasm targets that aren't Emscripten or Wasi.

daxpedda/web-time@dca3d82 changes this to cfg(all(target_family = "wasm", target_os = "unknown")), which says all Wasm targets that have an unknown target OS, which corresponds to wasm32-unknown-unknown exclusively.

This has no actual downstream effect, but it does protect against a potential new target, e.g. wasm32-unknown-newshinyos. For more on cfg in general see The Rust Reference.

Thank you, that makes a lot more sense!

BD103 avatar Feb 06 '24 14:02 BD103

Superseded by #12294.

dependabot[bot] avatar Mar 04 '24 07:03 dependabot[bot]