Jason comments

Repositories
Issues
Comments

Results 2 comments of


                                            Jason

Recursive types with Omit types leads to Reference Type Not Set Yet error since v1.0.0

I did the binary search as suggested and found the commit that causes the issue: 653fa77da0ce844227aab6fd82302ba15feafe2d. And this is the associated pull request: #985. Before that, it works fine. We...

fix(ws): close existing connections

Hi @benjGam This will be invoked in here: https://github.com/nestjs/nest/blob/master/packages/websockets/socket-module.ts#L108. Since `WsAdapter` extends `AbstractWsAdapter` the [`AbstractWsAdapter.close`](https://github.com/nestjs/nest/blob/master/packages/websockets/adapters/ws-adapter.ts#L37) method was called before this proposed change.