blackbox-log-viewer icon indicating copy to clipboard operation
blackbox-log-viewer copied to clipboard

Chore/formatting setup

Open chmelevskij opened this issue 1 year ago • 3 comments

This adds prettier and eslint configuration to automatically run linter on formatter as pre-commit hook.

For those ney sayers, we already have this setup for docs and no-one is complaining there, this one is copied from https://github.com/betaflight/betaflight.com

For the question Isn't sonar cloud doing this?, no it's not, it's happily reports code duplication when there is nothing change and then doesn't report real errors with logic Screenshot 2024-04-27 at 12 46 54

chmelevskij avatar Apr 27 '24 10:04 chmelevskij

Deploy Preview for origin-blackbox-logviewer ready!

Name Link
Latest commit 089aab03c01ba1df62789a596d098b5bbd6b53eb
Latest deploy log https://app.netlify.com/sites/origin-blackbox-logviewer/deploys/66936d42151e94000843ca00
Deploy Preview https://deploy-preview-735.dev.blackbox.betaflight.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 27 '24 10:04 netlify[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
8.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Apr 27 '24 10:04 sonarqubecloud[bot]

I've been suffering this in the Configurator. I'am all for including this kind of tools, but I don't like the way it hooks with the commit. Not everybody uses the same git tools, and not all the tools shows this in the same manner. Sometimes it gives errors that are difficult to be seen for the user, and the user can take a good amount of time to find it, fix it, and pushing it.

I know the idea is to get rid of them before the PR, but it seems to me that it can discourage new contributors when they have a git error that don't understand.

I know it will not be very popular, but I prefer a script that the user can execute (or integrate with VS Code), and that we can execute as a part of our Github Actions.

McGiverGim avatar May 09 '24 13:05 McGiverGim

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Jun 11 '24 04:06 github-actions[bot]

Pull request closed automatically as inactive.

github-actions[bot] avatar Jun 19 '24 04:06 github-actions[bot]

I've been suffering this in the Configurator. I'am all for including this kind of tools, but I don't like the way it hooks with the commit. Not everybody uses the same git tools, and not all the tools shows this in the same manner. Sometimes it gives errors that are difficult to be seen for the user, and the user can take a good amount of time to find it, fix it, and pushing it.

I know the idea is to get rid of them before the PR, but it seems to me that it can discourage new contributors when they have a git error that don't understand.

I know it will not be very popular, but I prefer a script that the user can execute (or integrate with VS Code), and that we can execute as a part of our Github Actions.

All the tools are available as a script version as well if you want to run them manualy. Please look at package.json.

chmelevskij avatar Jul 14 '24 06:07 chmelevskij