blackbox-log-viewer
blackbox-log-viewer copied to clipboard
Chore/formatting setup
This adds prettier and eslint configuration to automatically run linter on formatter as pre-commit hook.
For those ney sayers, we already have this setup for docs and no-one is complaining there, this one is copied from https://github.com/betaflight/betaflight.com
For the question Isn't sonar cloud doing this?, no it's not, it's happily reports code duplication when there is nothing change and then doesn't report real errors with logic
Deploy Preview for origin-blackbox-logviewer ready!
| Name | Link |
|---|---|
| Latest commit | 089aab03c01ba1df62789a596d098b5bbd6b53eb |
| Latest deploy log | https://app.netlify.com/sites/origin-blackbox-logviewer/deploys/66936d42151e94000843ca00 |
| Deploy Preview | https://deploy-preview-735.dev.blackbox.betaflight.com |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Quality Gate failed
Failed conditions
2 Security Hotspots
8.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
I've been suffering this in the Configurator. I'am all for including this kind of tools, but I don't like the way it hooks with the commit. Not everybody uses the same git tools, and not all the tools shows this in the same manner. Sometimes it gives errors that are difficult to be seen for the user, and the user can take a good amount of time to find it, fix it, and pushing it.
I know the idea is to get rid of them before the PR, but it seems to me that it can discourage new contributors when they have a git error that don't understand.
I know it will not be very popular, but I prefer a script that the user can execute (or integrate with VS Code), and that we can execute as a part of our Github Actions.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.
Pull request closed automatically as inactive.
I've been suffering this in the Configurator. I'am all for including this kind of tools, but I don't like the way it hooks with the commit. Not everybody uses the same git tools, and not all the tools shows this in the same manner. Sometimes it gives errors that are difficult to be seen for the user, and the user can take a good amount of time to find it, fix it, and pushing it.
I know the idea is to get rid of them before the PR, but it seems to me that it can discourage new contributors when they have a git error that don't understand.
I know it will not be very popular, but I prefer a script that the user can execute (or integrate with VS Code), and that we can execute as a part of our Github Actions.
All the tools are available as a script version as well if you want to run them manualy. Please look at package.json.