Added setting of minimum and maximum curves values on the graphs. VITE Web version.

[demvlad]

PR #689 for VITE Web.

[netlify[bot]]

✅ Deploy Preview for origin-blackbox-logviewer ready!

Name	Link
🔨 Latest commit	0c35172e6e7e088ded32d426122cc5a0419ed2a4
🔍 Latest deploy log	https://app.netlify.com/sites/origin-blackbox-logviewer/deploys/663b6d766af6290008bfe61e
😎 Deploy Preview	https://deploy-preview-726.dev.blackbox.betaflight.com
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nerdCopter]

maybe not be properly rebased. & Conflicting files

[demvlad]

maybe not be properly rebased.

Maybe! I do not understand. I've made rebase and resolved all conflicts. But there were too much conflicts after pushing branch. I've resolved their in the github online interface. Maybe this version will work:) If it will not, then i will repeate rebase.

[haslinghuis]

Probably need to drop only these ones:

[demvlad]

I've tried to load this version from github and run it. This is very wunderfull:), but it seems, the program is working! Will study, how to do rebase properly...

[demvlad]

Probably need to drop only these ones:

Yes, i am seeing these. Will try next time :) @haslinghuis @nerdCopter would you write me please, how can i do rebase properly in this case, when both branches have too much commits.

[haslinghuis]

git rebase -i HEAD~153 and drop the 3 commits. Save and force push.

Waiting for @nerdCopter for any alternatives.

[nerdCopter]

i like git rebase -i (interactive) as well. replaceing pick with drop for the suspect commits. when i perform that exact command, my editor shows 4 to maybe drop.

edit: but then i still get some conflicts :frowning:

maybe squashing can help. complexity has increased with 1000 commits

[demvlad]

Thank's. Can i do rebase like: rebase -i my_min_max_branch vite_veb_branch or rebase -i vite_veb_branch my_min_max_branch

What rebase direction is better?

[haslinghuis]

Something like that described here: https://git-scm.com/docs/git-rebase

[nerdCopter]

looks good :rocket:

[demvlad]

looks good 🚀

I've done rebase more accuratly. The test master merge has not any conflicts. I am going to push this version after a small bit time.

[nerdCopter]

i wonder now that it is PWA, are built-in browser based menus still bugged?

[demvlad]

i wonder now that it is PWA, are built-in browser based menus still bugged?

The olde nw.js menu? I've checked nw.js menu in simple html page by using browser, while wrote issue in NW. They had the bugs. I think, it will has the bugs in PWA too.

[demvlad]

looks good 🚀

I've done rebase more accuratly. The test master merge has not any conflicts. I am going to push this version after a small bit time.

Yes! The all rebase for wite web have not merge conflicts.

[demvlad]

Improvements: The menu is simple now. There are no submenues by default.

If the stanard menu is not enough for you and you want more features, then click menu item while the Shift key is pressed. And you will see the submenu with extended actions.

The Save item is removed from the menu, because it duplicated the 'Save' checkboxes in Chart setup dialog box. You need to use the 'Save' checkboxes in one case only: if you want to change default min-max values for some curves by using workspace slots or by loading next logs. If 'Save' checkbox is not checked for curve then it will use default presets min-max values by loading next logs or workspace charts preset. I do not like the 'Save' checkboxes name, because the charts configuration will save in any case when you press the Apply button at dialog box or press Shift+num key after that. I want to find other short name for these checkboxes.

[demvlad]

Improved: the right arrow markers are showed at menu items by pressing the Shift key to show the submenu activity. The default menu:

The menu with active submenu while Shift key is presed:

[demvlad]

I think, the "Default" tables caption in Chart setup dialog box is better then 'Save'.

[demvlad]

The workspace save strategy is changed #689.

I think, that are all till. I invite all participants for testing.

[demvlad]

The 'This curves' actions replaced into submenu. Finaly we have next variants menu:

Main menu default

Main menu with active submenu while the Shift key is pressed

'This curves' actions submenu

Main menu if the chart has one curve only

[demvlad]

Improvements: The Apply and Cancel buttons are enabled while menu is open. You can use it to close the dialog box without pressing of Back and Return menu items. The Alt (optionKey on Mac) key is used instead of Shift to use hidden submenu. The 'Full range' item of 'This curve' menu has submenu while Alt key is pressed. The 'Default' item on main menu has hidden submenu too. The menu source code structure is improved.

The issue of this version what i know, and their resolving at moment:

• sometime the Esc key is not working - to close menu by click at Back and Return menu item.
• sometime the right arrows are not showed on menu items while Alt key is pressed - continue to use submenu with Alt-key. The submenu are working really. There issues appear sometime after some mouse or keyboard actions while the menu is openned. There are some keyboard event handlers problem, i will resolve these.

The 'Full range' submenu on 'This curve' menu while Alt key is pressed.

[demvlad]

Resolved issue of Esc and Alt keys actions. I've found that in Vite Web version the Alt-key activate the browsers menu in Windows. Therefore in the Vite Web version i am using Shift-key.

[demvlad]

@ctzsnooze Please, check this update.

1. I've disable input autocompletion
2. The active top level 'Return' or 'Back' menu items have more smart design

I notice, that in WEB version the menu modify key is 'Shift', in no WEB - 'Alt'

This is link to current NO WEB version. https://github.com/demvlad/blackbox-log-viewer/tree/min_max_chart_settings I will continue to support this version. The all new updates in future will be on this link.

[demvlad]

@ctzsnooze I've reverted the all autocomplete preventions commits. Please check this version.

[demvlad]

Improvements:

• the curves expo is set to 100% as default (i did not remove it full till).
• added menu items actions to set min-max for marker selected time interval in extended submenu (by +Shift key)

[demvlad]

@ctzsnooze , the last issues are resolved. Updated:

• the 'Keep' checkboxes are removed from Charts setup dialog box
• the 'Grid' checkboxes are removed from Charts setup dialog box, the grid visibility is controled by On/Off button
• the main menu items actions close the menu
• the 'Return' main menu item is renamed to 'Close'

[demvlad]

Resolved error of data storage by using Expo, Grid, Smooth buttons

[demvlad]

THE MANUAL The MinMax PR can control curves scale and placement quickly and full. The current MinMax curves settings are showed at 'Configure graphs' dialog box in the "Minimum" and "Maximum" columns.

The MinMax values can be changed:

• By direct input into table cells at 'Configure graphs' dialog box. It is possible to changes values manualy or set default values by double mouse click at values field.
• By using context menu

To show context menu you must do right mouse click on Minimum or Maximum values field what you want to edit. The main context menu:

The main menu include following parts:

1. The menu actions to edit all curves
2. The menu actions to edit one curves what you selected by right mouse click (The 'Gyro pitch' for example at the picture)

The actions for all curves:

• 'Like this one' - apply MinMax of curve what you selected by right mouse click ('Gyro pitch' for example) to all curves.
• 'All to default' - set all curves MinMax values to default
• 'Zoom in', 'Zoom out' - change zoom for all curves
• 'Default' - set the all curves MinMax values to default
• 'Full range' - set the all curves MinMax values from Log file data during the all flight time
• 'One scale' - set all curves to one scale
• 'Centered' - The curves are centered around X-axis

The single curve submenu has same actions:

The main menu has extended mode. You need press the 'Shift' key to activate it and select the submenu, what you need.

The 'Like this one' extended submenu. You can change MinMax values and select curves what you need by using the checkboxes to apply these values. Click 'SET MIN-MAX VALUES' item for apply. Click 'Back' menu item to go back to main menu. Click 'Apply change' or 'Cancel' button on the main 'Configure graphs' dialog box to close the menu and dialog box immediately

The 'Zoom in', 'Zoom out' extended submenu. You can set the zoom procent value and select curves what you need by using the checkboxes to apply zoom. Click 'ZOOM IN', 'ZOOM OUT' items for apply zoom Click 'Back' menu item to go back to main menu. Click 'Apply change' or 'Cancel' button on the main 'Configure graphs' dialog box to close the menu and dialog box immediately

The 'Default' extended submenu. You can select curves what you need by using the checkboxes to apply default values. Click 'SET CURVES TO DEFAULT' item for apply Click 'Back' menu item to go back to main menu. Click 'Apply change' or 'Cancel' button on the main 'Configure graphs' dialog box to close the menu and dialog box immediately

The 'Full range' extended submenu. You can select curves what you need by using the checkboxes to apply values. Click 'At all global log time' menu item to set MinMax values from log data during all time. Click 'At local window time' menu item to set MinMax values from current time interval at the chart window. Click 'At markere time range' menu item to set MinMax values from markered time interval what you select by using "I", "O" keys. If it is not select then will apply all log time interval. Click 'Back' menu item to go back to main menu. Click 'Apply change' or 'Cancel' button on the main 'Configure graphs' dialog box to close the menu and dialog box immediately

The 'One scale' extended submenu. You can select curves what you need by using the checkboxes to set the same scale. Click 'SET SET CURVES TO SAME SCALE' item for apply Click 'Back' menu item to go back to main menu. Click 'Apply change' or 'Cancel' button on the main 'Configure graphs' dialog box to close the menu and dialog box immediately

The 'Centered' extended submenu. You can select curves what you need by using the checkboxes to centered. Click 'SET CURVES TO ZERO OFFSET' item for apply Click 'Back' menu item to go back to main menu. Click 'Apply change' or 'Cancel' button on the main 'Configure graphs' dialog box to close the menu and dialog box immediately

The single curve submenu has one 'Full range' extended item: It is like 'Full range' extended submenu, but for one selected curve only.

If you open context menu for one curves chart, then you see the short menu:

When you store the chart configuration in the workspace, the MinMax values stored for next using too.

This is non WEB version the PR: https://github.com/betaflight/blackbox-log-viewer/pull/689

[ctzsnooze]

Working REALLY WELL!! Absolutely love this PR. I can now quickly and easily set up the display exactly how I need it. Particularly helpful for debugs that don't have sensible scaling info. Ready to merge? I think so. Definitely ready for review.

[ctzsnooze]

May require a new workspaces file. Here's my current file. workspaces-ctzsnooze.json.zip