blackbox-log-viewer icon indicating copy to clipboard operation
blackbox-log-viewer copied to clipboard

Published 20 hours ago • verified publisher icon betaflight

Fix gps rescue throttle pid gains

Open ctzsnooze opened this issue 3 years ago • 4 comments

This PR is a simple one to:

  • update the GPS Rescue Altitude control Debug traces (PID and altitude),
  • add GPS Rescue Velocity control Debug traces (PID and velocity), and
  • update the RTH graphs and labels.

It is intended to properly display the new GPS Rescue debug traces from 11579

ctzsnooze avatar Apr 29 '22 01:04 ctzsnooze

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

blckmn avatar Apr 30 '22 05:04 blckmn

Not sure if I addressed all the issues above, if not please let me know.

Added another debug for https://github.com/betaflight/betaflight/pull/11579, tested.

ctzsnooze avatar May 15 '22 04:05 ctzsnooze

Not sure if I addressed all the issues above, if not please let me know.

I think my review has not been fixed, I don't see any change in the code about it.

McGiverGim avatar May 18 '22 10:05 McGiverGim

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
7.9% 7.9% Duplication

sonarqubecloud[bot] avatar Jun 01 '22 07:06 sonarqubecloud[bot]

Closing, replaced with #593

ctzsnooze avatar Aug 29 '22 01:08 ctzsnooze