Do you still release the addon on Firefox store?

[olivierperez]

My colleague uses this extension on chrome and I'm a bit jealous. So I tried to download it from the link in README.md but it seems that Firefox doesn't find it.

So here's my question, do you still release the add-on on Firefox store? Please tell me you can still do it 😍

[berzniz]

Technically yes, but the Mozilla team just pulled the extension from their store. I'm still looking at the reason, but they say they can not reproduce the build from the source code of the extension.

I'll get to that, but for now it can be installed in dev mode from the source.

[berzniz]

Here's the full information if anyone wants to help get it back to the Firefox store (cc @olivierperez):

Hello,


Due to issues discovered during the review process, your add-on Better Pull Request for GitHub has been disabled on [addons.mozilla.org](http://addons.mozilla.org/) and no longer appears in the gallery. Users who have previously installed your add-on will be able to continue using it.

Please see the reviewer's comments below for more information.

********
Details:
1) Extensions defining a content security policy that allows eval ('unsafe-eval') are generally not allowed for security and performance reasons.
- src/manifest.firefox.json line 51

In addition the following is required to complete the review:
1) We have built your add-on on Ubuntu 20.04 using node 14.17.2, npm 6.14.13, but the resulting code is different from the one in the add-on version. You can access our build from https://we.tl/t-0mwuU5zkwo (Link expires in 7 days).
Also, please test your build in a clean environment to make sure it is reproducible. If necessary, update the source package and/or the instructions to build.
********

Please address the issues raised in the reviewer's notes and inquire about any unclear items. Afterwards, please upload a new version of your add-on at https://addons.mozilla.org/en-US/developers/addon/better-pull-request-for-github/versions.

Thank you for your attention.

Also seem like they failed to build it... here's their output that they shared with me:

[olivierperez]

Hey, thanks for sharing this info. First, I think they executed yarn build (or yarn build-chrome) but not yarn build-firefox, so I guess they won't have the same output as you (the zip contains a "chrome" folder instead of the "firefox" one).

Then I'm not at home right now, but I think I got the same output zip file (but for Firefox of course). I remember the error messages you can see in the generated .js files: "ATTENTION: The "eval" devtool has been used (maybe by default in mode: "development")...".

Good to know: I built it on Windows.

[olivierperez]

I confirm, I get the same error, see how background.js is generated with command yarn build-firefox background.zip

However, I get no issues if I execute deploy_firefox_store.sh (after some adjustment in it, because I don't have "zip" and "json" binaries).

@berzniz are you able to ask them how they generated the zip?

[j0hnsmith]

I've been hoping this would be solved quickly so I could install this plugin but just noticed that github now provides this functionality. Guess this extension, and others like it, are no longer necessary.

[marad]

@j0hnsmith the one in GH is rudimentary and lack a lot of features. Will probably get better in the future, but for now it's not a match for plugins like this one. I'd still very welcome the firefox version.

[bluzky]

Github supports file tree for PR, but you have to enable it first. I found this post on dev.to https://dev.to/n3wt0n/github-new-file-tree-view-in-pull-requests-a-huge-productivity-boost-38e3

[starkers]

GitHubs (beta) PR tree is not as good as this plugin.. can't resize, ugly navigation and easy to get confused cause of how they collapse trees in their implementation

[j0hnsmith]

GitHubs (beta) PR tree is not as good as this plugin

Great, I look forward to this plugin being available again.

[yermulnik]

Sorry for spamming with comment updates 🙇🏻 I've finally managed to build, get it signed and installed. It's 1.0.38 from the master branch and it works in FF as expected 🚀

Used this guide to upload, get it signed, and download: https://extensionworkshop.com/documentation/publish/submitting-an-add-on/#self-distribution