ocrd_detectron2 icon indicating copy to clipboard operation
ocrd_detectron2 copied to clipboard

Fix order of import statements for shapely issue

Open stweil opened this issue 2 years ago • 2 comments
trafficstars

stweil avatar Jun 22 '23 08:06 stweil

It's true that such less obvious imports make it difficult to find all affected code locations by a simple code inspection.

But it would still be possible to fix the issue like that case by case.

The current workaround to run pip install --no-binary shapely --force-reinstall shapely has also drawbacks.

stweil avatar Jun 22 '23 10:06 stweil

I agree in principle. But we know that core itself, which is used everywhere (CLI decorators), always imports shapely (via ocrd_validators, via ocrd) – before anything else. So that would need to be solved first...

bertsky avatar Jun 22 '23 11:06 bertsky