Robert Sachunsky

Results 721 comments of Robert Sachunsky
trafficstars

As soon as all linked PRs are addressed, we can remove `ocrd_neat` from https://github.com/OCR-D/ocrd_all/blob/6cd9f7d92a71c359697ea4bd3d3edb11d1e0f340/Makefile#L72 BTW, what's the reason for this module name here, @kba? (Why not just page2tsv?)

To be precise, in this case the message from TF logging causing the hickup was not a warning (as the issue suggests) but an error. All our TF-based processors now...

> So perhaps we should do our own `basicConfig(handlers=[logging.NullHandler()], force=True)`, or alternatively just call `logging.disable(sys.maxsize)` in core's `ocrd_cli_wrap_processor` (which will be before any processor-specific imports)? Duh! That by itself won't...

> So perhaps we should make sure that our processors don't make imports other than OCR-D related …which in the case of ocrd_calamari is tricky: it wants to `from tensorflow...

In another example, I get garbled JSON from the following error: ``` /ocrd_all/venv38/lib/python3.8/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.12) or chardet (5.2.0)/charset_normalizer (2.0.12) doesn't match a supported version! warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer...

Regarding the `urllib3` problem – for anyone who encounters this, the fix is to update `requests` as specified by core: pip install -U "requests

> So perhaps we should make sure that our processors don't make imports other than OCR-D related – until required to do `process()`. That would also speed up responses for...

@kba @MehmedGIT what do you think? Should I move `initLogging` to the top of `ocrd_cli_wrap_processor` (covering all CLI use cases of a processor, not just processing)? Only in v3, or...

Could this be related to https://github.com/OCR-D/core/issues/1149 (as internally, the bagger also just uses [Resolver.download_to_directory](https://github.com/OCR-D/core/blob/4a5d9b37d846617e7293e9ebb23d14f2bbd56561/src/ocrd/workspace_bagger.py#L84) as does clone/workspace_from_url)?

> ```c > File "/home/mm/venv38-all/lib/python3.8/site-packages/ocrd_cis/ocropy/segment.py", line 951, in add_baseline > assert all(p1[0] < p2[0] for p1, p2 in zip(result[:-1], result[1:])), result > AssertionError: [(52.0, 277.0), (74.5, 279.5), (77.875, 279.875), (88.0,...