Robert Sachunsky

Results 721 comments of Robert Sachunsky
trafficstars

Thanks @stefanCCS for the report and @mexthecat for the analysis! IIUC `resolve()` must indeed be replaced by `absolute`, and that this causes not only the validator but also all processors...

@kba this is a very nasty bug that prevents `--overwrite` for me in a lot of cases (and makes repairing the METS afterwards very hard). RFC

(For example, this problem has surfaced in `ocrd-tesserocr-segment-line` which led to a local workaround there as OCR-D/ocrd_tesserocr#104 and OCR-D/ocrd_tesserocr#120, and in `ocrd-anybaseocr-block-segmentation` as OCR-D/ocrd_anybaseocr/pull/27)

See [here](https://github.com/cisocrgroup/ocrd_cis/pull/48/commits/01638c45d6b777adccf03ad457e2b75909ea107f) for an idea of what could/should really be done in core. Working with many different libraries (Shapely, OpenCV, Scikit) it's still [surprisingly hard](https://github.com/cisocrgroup/ocrd_cis/pull/48/commits/721c3e13588993047739a5844389cca2c7686130) to calculate contour polygons in...

This could also be part of an OCR-D adaptor to [PAGE-XML _pixel-center_ coordinate convention](https://github.com/PRImA-Research-Lab/PAGE-XML/issues/23) – if that does turn out to be the binding interpretation. We could make `coordinates_of_segment` convert...

> Or can we? How about making it polymorphic and checking the type of the first argument, as an opt-in for implicit conversion consistent with parent? No we cannot! The...

On the other hand – forgive my confusion – since d6c51ca5f40090e2a6ac305b034f124b05f4edd9 we should actually not see any difference, because we already re-crop after rotation whenever possible.

> On the other hand – forgive my confusion – since [d6c51ca](https://github.com/OCR-D/core/commit/d6c51ca5f40090e2a6ac305b034f124b05f4edd9) we should actually not see any difference, because we already re-crop after rotation whenever possible. Darn! I think...

> I think that commit was (well intentioned but) still flawed: when re-cropping via `_crop()`, which is the general function, it would first check whether `cropped` already applied on the...