Robert Sachunsky

Results 728 comments of Robert Sachunsky
trafficstars

> But I don't know of any OS-independent checks besides things like `pkg-config`. Plus we have many more dependencies besides just libraries. Thus, along the _host adaptor_ idea, maybe all...

> We could even go so far to install custom `apt` dummies under our venv PATH, so that `deps-ubuntu` etc will work ever after. This would need to sneak past...

> `make clean` removes venv directory in source path unconditionally > Ideally it would only remove files created by the build process. > > If the user has created the...

>```diff > - $(RM) -r $(CURDIR)/venv # deliberately not using VIRTUAL_ENV here > + # Remove virtual environment only if it was not active outside of the make context. >...

> `make all -j6` starts with downloading all submodules, 6 at a time, but because of the semaphore required for git all downloads happen sequentially. Yes, that is unfortunate. But...

Thanks for your report! Note that there's already a solution for this in the line [in ocrd_cis](https://github.com/cisocrgroup/ocrd_cis/pull/83), but before we can adapt ocrd_cis to the new resmgr I'll have to...

> However, in light of the above comment, how useful is this? Will it still perform corrections and to what extent will the rate of corrections drop without the Profiler?...

I happen to know Wito did `sudo make deps-ubuntu`, but judging by https://github.com/bertsky/ocrd_detectron2/issues/13 I believe that did **not** pull in python3-dev. Also, I cannot see it anywhere in the Makefile...

> It's in `README.md`, one of the requirements which must be fulfilled before anything else (part of getting Python which it installs as a dependency). But it doesn't. We have...

> Sorry, I was wrong. `Makefile` already installs the required package conditionally using `apt-get install -y --no-install-recommends $(notdir $(PYTHON))-dev $(notdir $(PYTHON))-venv`. I only searched for `python.*-dev` which did not match....