benyamin-codez

Results 134 comments of benyamin-codez

Shares some definitions with PR #1298. Waiting for that to merge before rebasing.

@vrozenfe Happy to help Vadim. Can do the split. Gives me chance to fix ProcessQueue() too (https://github.com/virtio-win/kvm-guest-drivers-windows/pull/1135/files#diff-b8f1732536a5020c949209736b628a0af83022fbbded42c0eaef7bc3149dd6c3L1475-R1493)... I can probably run up some comparisons again too. I'll use `diskspd` and...

@JonKohler Thanks for the contribution and review Jon. I'll take the housekeeping on board and I'm happy to share my stat collector scripts and results too. Give me a couple...

@frwbr Thanks for dropping your post above, Friedrich, and for taking the time to build and test it out. For those interested, check out my [inline reply](https://github.com/virtio-win/kvm-guest-drivers-windows/pull/1135/files#r1725364626).

@vrozenfe @JonKohler @sb-ntnx @frwbr @foxmox Please bear in mind that despite fixing the issue mentioned in #756 the performance is not reliable. Given I've got limited time over the next...

@JonKohler @frwbr, I agree with you both. I think we are all on the same page. I've got some answers to your questions Friedrich. I'm pretty sure I'm on a...

For those watching: I've spent a couple more hours tracing this through, and it looks like we have at least three issues. First, the issue of notifications. That seems to...

For those watching: I think I'm almost done and hope to provide a report here in the next 12 to 24 hours. I'll then split up the commits into new...

A somewhat belated progress report: So I've had trouble reproducing faults with `diskspd.exe` test files containing random data. The faults do occur with zeroed test files, which I find quite...