BentoML icon indicating copy to clipboard operation
BentoML copied to clipboard

feature: Support for poetry for installing dependencies in bento

Open arkodoescode opened this issue 2 years ago • 8 comments
trafficstars

Feature request

I would like it if bentofile python field could support a pyproject.toml value in requirements instead of a requirements.txt file with support for poetry.

Motivation

Poetry is used in production quite a lot and this seems like a natural choice.

Other

No response

arkodoescode avatar Jul 02 '23 14:07 arkodoescode

Agree. It makes sense to support PEP 621. And the good news is pip-tools (we are using it to lock the dependencies) already supports it. Thus it should be a natural change. https://github.com/jazzband/pip-tools/issues/1510

bojiang avatar Jul 03 '23 02:07 bojiang

Would you like to help adding this feature?

bojiang avatar Jul 03 '23 02:07 bojiang

I think adding poetry is nice, but it is just adding a churn for us to maintain.

Esp in the past, we haven't had good experiences with poetry. Not sure if this has changed with the recent release. Maybe we can add support for pdm since we have @frostming 😃

aarnphm avatar Jul 31 '23 04:07 aarnphm

Would you like to help adding this feature?

arkodoescode avatar Aug 14 '23 04:08 arkodoescode

Would you like to help adding this feature?

I would love to help if and when I have bandwidth.

arkodoescode avatar Aug 14 '23 04:08 arkodoescode

I think a better discussion is to make bento pip-installable, rather than supporting specific backend for installation. Because at the end of the day, I think all packages can/should just be installed with pip within an isolated container.

aarnphm avatar Aug 14 '23 20:08 aarnphm

Any updates on this? It would be great addition IMO

ianwesleyarmstrong avatar Oct 21 '23 17:10 ianwesleyarmstrong

@frostming I think for Bento it can also generate a pyproject.toml. with this it will probably support whatever framework backend for PEP621

Would be a great feature for this is to make pip-installable bento, probably an adjacent feature

aarnphm avatar Oct 22 '23 18:10 aarnphm