BentoML icon indicating copy to clipboard operation
BentoML copied to clipboard

feat: Add SSL support for http api servers via bentoml serve

Open sptowey opened this issue 3 years ago • 3 comments

What does this PR address?

Before submitting:

Who can help review?

@ssheng @sauyon

Feel free to tag members/contributors who can help review your PR.

sptowey avatar Aug 09 '22 21:08 sptowey

Hello @sptowey, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! :beers:

Comment last updated at 2022-08-11 19:51:29 UTC

pep8speaks avatar Aug 09 '22 21:08 pep8speaks

Codecov Report

Merging #2886 (9fbcba4) into main (ce6342d) will increase coverage by 0.14%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
+ Coverage   70.70%   70.85%   +0.14%     
==========================================
  Files         103      103              
  Lines        9302     9328      +26     
==========================================
+ Hits         6577     6609      +32     
+ Misses       2725     2719       -6     
Impacted Files Coverage Δ
bentoml/_internal/configuration/containers.py 80.70% <ø> (ø)
bentoml/_internal/utils/docker.py 68.96% <0.00%> (-4.95%) :arrow_down:
bentoml/_internal/yatai_client/__init__.py 25.00% <0.00%> (-0.51%) :arrow_down:
bentoml/_internal/runner/runnable.py 93.75% <0.00%> (+1.56%) :arrow_up:
bentoml/_internal/utils/analytics/usage_stats.py 96.42% <0.00%> (+18.81%) :arrow_up:

codecov[bot] avatar Aug 10 '22 08:08 codecov[bot]

Thanks for the contribution. Make sure to run make format and make lint locally 🎉

Whoops, I ran the linter but missed the formatter!

sptowey avatar Aug 10 '22 13:08 sptowey