BentoML
BentoML copied to clipboard
feat: Add SSL support for http api servers via bentoml serve
What does this PR address?
Before submitting:
- [x] Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's guide on how to create a pull request.
- [x] Does the code follow BentoML's code style, both
make formatandmake lintscript have passed (instructions)? - [x] Did you read through contribution guidelines and follow development guidelines?
- [x] Did your changes require updates to the documentation? Have you updated those accordingly? Here are documentation guidelines and tips on writting docs.
- [ ] Did you write tests to cover your changes? N/A - cleared with Sean in Slack
Who can help review?
@ssheng @sauyon
Feel free to tag members/contributors who can help review your PR.
Hello @sptowey, Thanks for updating this PR.
There are currently no PEP 8 issues detected in this PR. Cheers! :beers:
Comment last updated at 2022-08-11 19:51:29 UTC
Codecov Report
Merging #2886 (9fbcba4) into main (ce6342d) will increase coverage by
0.14%. The diff coverage isn/a.
@@ Coverage Diff @@
## main #2886 +/- ##
==========================================
+ Coverage 70.70% 70.85% +0.14%
==========================================
Files 103 103
Lines 9302 9328 +26
==========================================
+ Hits 6577 6609 +32
+ Misses 2725 2719 -6
| Impacted Files | Coverage Δ | |
|---|---|---|
| bentoml/_internal/configuration/containers.py | 80.70% <ø> (ø) |
|
| bentoml/_internal/utils/docker.py | 68.96% <0.00%> (-4.95%) |
:arrow_down: |
| bentoml/_internal/yatai_client/__init__.py | 25.00% <0.00%> (-0.51%) |
:arrow_down: |
| bentoml/_internal/runner/runnable.py | 93.75% <0.00%> (+1.56%) |
:arrow_up: |
| bentoml/_internal/utils/analytics/usage_stats.py | 96.42% <0.00%> (+18.81%) |
:arrow_up: |
Thanks for the contribution. Make sure to run
make formatandmake lintlocally 🎉
Whoops, I ran the linter but missed the formatter!