computer-science-in-javascript

computer-science-in-javascript copied to clipboard

Priority Queue missing

1

There is no implementation of Priority Queue in this project. Priority Queue is a very important data structure and it should be included in this project as well.

sukheja-varun

sukheja-varun

SamanShafigh

Thanks for these files! I've been studying them and I think there was extra code in the innermost 'if' condition.

CameronPennington

bubble-sort.js

1

is there a known issue for sorting when there is 0 in the array, I used a code similar to the one that you used in bubble-sort.js , but whenever...

AliSalman86

Splice changes array.length and shifts remaining elements 1 place. Test: const tree = new Tree(); tree.add('ceo'); tree.add('cto1', 'ceo'); tree.add('cto2', 'ceo'); tree.add('cto3', 'ceo'); tree.add('dev1', 'cto1'); tree.add('dev2', 'cto1'); tree.add('dev3', 'cto1'); tree.add('dev2', 'dev3');...

tenthirtyone

https://github.com/benoitvallon/computer-science-in-javascript/blob/master/data-structures-in-javascript/tree.es6.js#L33 Splice in the for loop shifts the elements in the array and skips the sibling of the node that was removed. Fix PR: You can test with: ``` const...

tenthirtyone

Just wanted to practice a bit of js and thought that this might make the code a bit more generic. - Edits to the efficiency of the doubly linked list...

ChristopherBlackman

RohitPaul0007

RohitPaul0007