go-weasyprint icon indicating copy to clipboard operation
go-weasyprint copied to clipboard

Published 20 hours ago • verified publisher icon benoitkugler

Addition of test suite

Open kishaningithub opened this issue 1 year ago • 2 comments

Would be great of this package has running CI tests in github actions.

kishaningithub avatar Aug 17 '24 03:08 kishaningithub

Sure thing ! Would you like to open a PR to do so ?

benoitkugler avatar Aug 17 '24 08:08 benoitkugler

Sure will do

kishaningithub avatar Aug 18 '24 12:08 kishaningithub

Have created PR https://github.com/benoitkugler/go-weasyprint/pull/8 to address this

When the tests are running i see the below error (screenshot below) can you kindly help out?

image

kishaningithub avatar Aug 20 '24 05:08 kishaningithub

Almost all the tests use a font index, which must be generated at least once. I guess some tests incorrectly assume it has been done. It should be simple enough to fix, I'll look into it when I'm back behind a computer.

benoitkugler avatar Aug 20 '24 13:08 benoitkugler

The last few commits have resolved the issue. Thank you for adding this test suite !

benoitkugler avatar Aug 26 '24 13:08 benoitkugler