Ben Thomson

Results 235 comments of Ben Thomson

Well that's gonna make my latest branch stick out like a sore thumb... 😅

@canthis I don't believe they've ever been cached, or picked up for that matter, since it's routed through the main Backend Controller class.

@LukeTowers @canthis happy to tackle that in another PR, this one should at least fix the immediate issue of the site breaking if someone uses `route:cache`.

@LukeTowers I thought our extended `UrlGenerator` just adds the static method `buildUrl`, so it wouldn't matter, but I just realised that we also overwrite the `to` method. So I'll probably...

@LukeTowers ah yeah, I remember you showing me that once before. That'd work nicely!

@WebVPF @LukeTowers this appears to break the unit tests since they are doing string comparisons on some exceptions. Also, I believe our standard is to not translate system exceptions.

Some good ideas here @joho1968 - we'll definitely look into them for future versions.

@RomainMazB > As a side note, it could be more clear to pull back almost all of [this wintercms/winter test folder](https://github.com/wintercms/winter/tree/develop/modules/system/tests/plugins/database) inside winter/storm as most of the tests are more...

@mjauvin I've tweaked the property names and did some clean up of the Extendable trait. Feel free to revert if you disagree with it all :)