Ben Thomson

Results 241 comments of Ben Thomson

I agree with @mjauvin. It's the least intrusive and destructive. If someone wants to be clever with their naming, they will most certainly be skilled enough to find the file...

@LukeTowers it's already been changed to the Icon Picker, just waiting on a new release which I'm working on now - https://github.com/wintercms/wn-builder-plugin/commit/1a9c2f912c14e18631e5ea53ca6b560d43ba8aef.

@LukeTowers the only specific opening this would provide would be if one were to be accepting any form of user input into a content block - they could put in...

@LukeTowers slightly less horrible, but the other idea is we could add that sequence to the escaping functionality within Twig, so if it's fed through a Twig variable, it's escaped,...

@mjauvin because the content blocks are cached on render. Putting in the variables before rendering would lock that set of variables in, and you'd lose the ability to re-use the...

@LukeTowers it basically requires us to completely replace one of the core Commonmark extensions with our own copy of the same extension (plus any overrides to make the links work...

It should. I'll have to circle around to this in a couple of weeks though unfortunately. Currently knee-deep in a very time-critical project.

@LukeTowers just circling back to this - I'm wondering if we even need Twig escaping? The particular issue here is with content blocks that are Markdown-formatted. Content blocks aren't put...

I really don't like this fix, TBH. I'm more inclined to can it and think of something else.

I'm not opposed to us adding in a check for a `forceDelete` parameter that could be defined with the data request and interpreted by the `onDelete` action in the `FormController`...